From 244e4d209fe13d3bf99d631e35131706ce60eefb Mon Sep 17 00:00:00 2001
From: Matthieu Gautier <mgautier@kymeria.fr>
Date: Wed, 28 Aug 2024 14:03:34 +0200
Subject: [PATCH] Add icu dlls in nightly and releases

On windows, we use prebuild icu and is available as dll.

So we must include those dll in all our archives.
---
 .github/scripts/common.py | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/scripts/common.py b/.github/scripts/common.py
index a386355..c6d8f24 100644
--- a/.github/scripts/common.py
+++ b/.github/scripts/common.py
@@ -73,7 +73,8 @@ def major_version(version: str) -> str:
 EXPORT_FILES = {
     "kiwix-tools": (
         INSTALL_DIR / "bin",
-        [f + BIN_EXT for f in ("kiwix-manage", "kiwix-search", "kiwix-serve")],
+        [f + BIN_EXT for f in ("kiwix-manage", "kiwix-search", "kiwix-serve")]
+        + ["icu*.dll"],
     ),
     "zim-tools": (
         INSTALL_DIR / "bin",
@@ -90,7 +91,8 @@ EXPORT_FILES = {
                 "zimwriterfs",
                 "zimrecreate",
             )
-        ],
+        ]
+        + ["icu*.dll"],
     ),
     "libzim": (
         INSTALL_DIR,
@@ -110,6 +112,7 @@ EXPORT_FILES = {
             "bin/zim-{version}.dll".format(
                 version=major_version(main_project_versions["libzim"])
             ),
+            "bin/icu*.dll",
             "bin/zim-{version}.pdb".format(
                 version=major_version(main_project_versions["libzim"])
             ),
@@ -134,6 +137,7 @@ EXPORT_FILES = {
             "lib/libkiwix.{}.dylib".format(
                 major_version(main_project_versions["libkiwix"])
             ),
+            "bin/icu*.dll",
             "lib/libkiwix.dylib",
             "lib/*/libkiwix.pc",
             "include/kiwix/**/*.h",