From 462538f4a565ba6c820774a053d432a08a8f7f18 Mon Sep 17 00:00:00 2001 From: Matthieu Gautier Date: Thu, 23 Dec 2021 19:01:15 +0100 Subject: [PATCH] Do not try to cross compile aria2. Aria2 is a special case. We actually don't really need to compile it. kiwix-desktop through libkiwix use the aria2c binary but we always use (package) the system binary or a prebuild release. And we don't cross compile kiwix-desktop to windows, so we don't need aria2c neither. --- kiwixbuild/dependencies/all_dependencies.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kiwixbuild/dependencies/all_dependencies.py b/kiwixbuild/dependencies/all_dependencies.py index a33bb64..0be910c 100644 --- a/kiwixbuild/dependencies/all_dependencies.py +++ b/kiwixbuild/dependencies/all_dependencies.py @@ -17,10 +17,11 @@ class AllBaseDependencies(Dependency): if platformInfo.build not in ('android', 'iOS'): # For zimtools base_deps += ['docoptcpp'] - # For kiwix-desktop - base_deps += ['aria2'] if platformInfo.build != 'win32': # zimwriterfs base_deps += ['libmagic', 'gumbo'] - + if platformInfo.build == 'native' and neutralEnv('distname') != 'Darwin': + # We compile kiwix-desktop only on native and not on `Darwin` + # So we need aria2 only there + base_deps += ['aria2'] return base_deps