From 079e03473b405cad805712bfe7eeb8eee8e58d33 Mon Sep 17 00:00:00 2001 From: renaud gaudin Date: Tue, 23 Mar 2021 11:59:49 +0000 Subject: [PATCH] Change time server in workflow For the past week, the Release&Nightly workflow failed on macOS native_mixed (but not on native_dyn) when calling ntp to sync clock before signing. Calling time.apple.com resulted in a DNS error, leading to an error in ntp call Why this fails on native_mixed is unknown. Maybe because it's being called twice from the same (I guess) host in a short interleave? This attempts to fix this by: - using google's time server instead of Apple's - correctly setting the timeout param before the server name (although not relevant for this dns-based error) - Ignore failures to sync time. We're doing it to minimize chances of unsynched clocks to fail the signature but this is not absolutely required all the time. --- .github/workflows/releaseNigthly.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/releaseNigthly.yml b/.github/workflows/releaseNigthly.yml index 7fa76b3..e3fae4d 100644 --- a/.github/workflows/releaseNigthly.yml +++ b/.github/workflows/releaseNigthly.yml @@ -166,7 +166,7 @@ jobs: rm $CERTIFICATE security set-key-partition-list -S "apple-tool:,apple:" -s -k mysecretpassword build.keychain security find-identity -v - sudo sntp -sS time.apple.com -t 60 + sudo sntp -sS -t 60 time4.google.com || true xcrun altool --store-password-in-keychain-item "ALTOOL_PASSWORD" -u "$ALTOOL_USERNAME" -p "${{ secrets.APPLE_SIGNING_ALTOOL_PASSWORD }}" - name: Ensure base deps shell: bash