From 0586ef6d41ca24eabb84973fd67f72ed6ac5a227 Mon Sep 17 00:00:00 2001 From: luddens Date: Mon, 13 Apr 2020 16:07:27 +0200 Subject: [PATCH] fix open external zim Check if the parameter `pathToSave` is empty before use it otherwise the book path is empty too, which causes crash on opening external zim files --- src/manager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/manager.cpp b/src/manager.cpp index a524d380b..7e4540d77 100644 --- a/src/manager.cpp +++ b/src/manager.cpp @@ -175,7 +175,7 @@ std::string Manager::addBookFromPathAndGetId(const std::string& pathToOpen, kiwix::Book book; if (this->readBookFromPath(pathToOpen, &book)) { - if (pathToSave != pathToOpen) { + if (!pathToSave.empty() && pathToSave != pathToOpen) { book.setPath(isRelativePath(pathToSave) ? computeAbsolutePath( removeLastPathElement(writableLibraryPath),