From 07c7d3931d2d28381387250ab60a449d646f5883 Mon Sep 17 00:00:00 2001
From: Veloman Yunkan <veloman.yunkan@gmail.com>
Date: Tue, 17 Jan 2023 19:01:50 +0400
Subject: [PATCH] Added a unit-test of buggy urlEncode()

Added a unit-test for urlEncode() that passes for its current
implementation despite the two bugs that were revealed while creating
the unit-test.
---
 test/stringTools.cpp | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/test/stringTools.cpp b/test/stringTools.cpp
index 7402f6e0d..b6965f8fb 100644
--- a/test/stringTools.cpp
+++ b/test/stringTools.cpp
@@ -105,4 +105,48 @@ TEST(stringTools, extractFromString)
   ASSERT_THROW(extractFromString<float>("3.14.5"), std::invalid_argument);
 }
 
+namespace URLEncoding
+{
+
+const char letters[] = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ";
+const char digits[] = "0123456789";
+const char nonEncodableSymbols[] = ".-_~()*!";
+const char uriDelimSymbols[] = ":/@?=+&$;,";
+
+// XXX: # should belong to uriDelimSymbols!
+const char otherSymbols[] = R"(`#%^[]{}\|"<>)";
+
+const char whitespace[] = " \n\t\r";
+
+const char someNonASCIIChars[] = "Σ♂♀ツ";
+
+}
+
+TEST(stringTools, urlEncode)
+{
+  using namespace URLEncoding;
+
+  EXPECT_EQ(urlEncode(letters),       letters);
+  EXPECT_EQ(urlEncode(letters, true), letters);
+
+  EXPECT_EQ(urlEncode(digits),       digits);
+  EXPECT_EQ(urlEncode(digits, true), digits);
+
+  EXPECT_EQ(urlEncode(nonEncodableSymbols),       nonEncodableSymbols);
+  EXPECT_EQ(urlEncode(nonEncodableSymbols, true), nonEncodableSymbols);
+
+  EXPECT_EQ(urlEncode(uriDelimSymbols), uriDelimSymbols);
+  EXPECT_EQ(urlEncode(uriDelimSymbols, true), "%3A%2F%40%3F%3D%2B%26%24%3B%2C");
+
+  EXPECT_EQ(urlEncode(otherSymbols), "%60%23%25%5E%5B%5D%7B%7D%5C%7C%22%3C%3E");
+  EXPECT_EQ(urlEncode(otherSymbols), urlEncode(otherSymbols, true));
+
+  // XXX: there is a bug with formatting of single-digit hex values
+  EXPECT_EQ(urlEncode(whitespace), "%20% A% 9% D");
+  EXPECT_EQ(urlEncode(whitespace), urlEncode(whitespace, true));
+
+  EXPECT_EQ(urlEncode(someNonASCIIChars), "%CE%A3%E2%99%82%E2%99%80%E3%83%84");
+  EXPECT_EQ(urlEncode(someNonASCIIChars), urlEncode(someNonASCIIChars, true));
+}
+
 };