smallsolar/libkiwix
1
0
Fork 0
mirror of https://github.com/kiwix/libkiwix.git synced 2025-06-26 10:11:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make Downloader return shared_ptr instead of raw pointer.

Browse Source 
This is dangerous by nature to return raw pointer on internal data.
This commit is contained in:
Matthieu Gautier
2023-02-07 10:55:57 +01:00
parent 52ae5c3a5f
commit 0e612de4d1
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
include/downloader.h
View File

@ -93,15 +93,15 @@ class Downloader
void close();
Download* startDownload(const std::string& uri, const std::vector<std::pair<std::string, std::string>>& options = {});
Download* getDownload(const std::string& did);
std::shared_ptr<Download> startDownload(const std::string& uri, const std::vector<std::pair<std::string, std::string>>& options = {});
std::shared_ptr<Download> getDownload(const std::string& did);
size_t getNbDownload();
std::vector<std::string> getDownloadIds();
private:
std::mutex m_lock;
std::map<std::string, std::unique_ptr<Download>> m_knownDownloads;
std::map<std::string, std::shared_ptr<Download>> m_knownDownloads;
std::shared_ptr<Aria2> mp_aria;
};
}