Mark constant methods as const.

This commit is contained in:
Matthieu Gautier
2023-02-07 11:00:27 +01:00
parent 0e612de4d1
commit 18b7b5f277
2 changed files with 14 additions and 14 deletions

View File

@ -58,15 +58,15 @@ class Download {
void pauseDownload(); void pauseDownload();
void resumeDownload(); void resumeDownload();
void cancelDownload(); void cancelDownload();
StatusResult getStatus() { return m_status; } StatusResult getStatus() const { return m_status; }
std::string getDid() { return m_did; } const std::string& getDid() const { return m_did; }
std::string getFollowedBy() { return m_followedBy; } const std::string& getFollowedBy() const { return m_followedBy; }
uint64_t getTotalLength() { return m_totalLength; } uint64_t getTotalLength() const { return m_totalLength; }
uint64_t getCompletedLength() { return m_completedLength; } uint64_t getCompletedLength() const { return m_completedLength; }
uint64_t getDownloadSpeed() { return m_downloadSpeed; } uint64_t getDownloadSpeed() const { return m_downloadSpeed; }
uint64_t getVerifiedLength() { return m_verifiedLength; } uint64_t getVerifiedLength() const { return m_verifiedLength; }
std::string getPath() { return m_path; } const std::string& getPath() const { return m_path; }
std::vector<std::string>& getUris() { return m_uris; } const std::vector<std::string>& getUris() const { return m_uris; }
protected: protected:
std::shared_ptr<Aria2> mp_aria; std::shared_ptr<Aria2> mp_aria;
@ -96,11 +96,11 @@ class Downloader
std::shared_ptr<Download> startDownload(const std::string& uri, const std::vector<std::pair<std::string, std::string>>& options = {}); std::shared_ptr<Download> startDownload(const std::string& uri, const std::vector<std::pair<std::string, std::string>>& options = {});
std::shared_ptr<Download> getDownload(const std::string& did); std::shared_ptr<Download> getDownload(const std::string& did);
size_t getNbDownload(); size_t getNbDownload() const;
std::vector<std::string> getDownloadIds(); std::vector<std::string> getDownloadIds() const;
private: private:
std::mutex m_lock; mutable std::mutex m_lock;
std::map<std::string, std::shared_ptr<Download>> m_knownDownloads; std::map<std::string, std::shared_ptr<Download>> m_knownDownloads;
std::shared_ptr<Aria2> mp_aria; std::shared_ptr<Aria2> mp_aria;
}; };

View File

@ -155,7 +155,7 @@ void Downloader::close()
mp_aria->close(); mp_aria->close();
} }
std::vector<std::string> Downloader::getDownloadIds() { std::vector<std::string> Downloader::getDownloadIds() const {
std::unique_lock<std::mutex> lock(m_lock); std::unique_lock<std::mutex> lock(m_lock);
std::vector<std::string> ret; std::vector<std::string> ret;
for(auto& p:m_knownDownloads) { for(auto& p:m_knownDownloads) {
@ -201,7 +201,7 @@ std::shared_ptr<Download> Downloader::getDownload(const std::string& did)
} }
} }
size_t Downloader::getNbDownload() { size_t Downloader::getNbDownload() const {
std::unique_lock<std::mutex> lock(m_lock); std::unique_lock<std::mutex> lock(m_lock);
return m_knownDownloads.size(); return m_knownDownloads.size();
} }