From 1d5383435d5da63c00dbfb1e8f40e2d8d606e731 Mon Sep 17 00:00:00 2001
From: Veloman Yunkan <veloman.yunkan@gmail.com>
Date: Sun, 28 Nov 2021 20:04:10 +0400
Subject: [PATCH] Noted a potential bug in Library::addBook()

---
 src/library.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/library.cpp b/src/library.cpp
index 55ed39cd2..3518e2b0c 100644
--- a/src/library.cpp
+++ b/src/library.cpp
@@ -108,7 +108,9 @@ bool Library::addBook(const Book& book)
     if ( ! booksReferToTheSameArchive(oldbook, book) ) {
       dropReader(book.getId());
     }
-    oldbook.update(book);
+    oldbook.update(book); // XXX: This may have no effect if oldbook is readonly
+                          // XXX: Then m_bookDB will become out-of-sync with
+                          // XXX: the real contents of the library.
     return false;
   } catch (std::out_of_range&) {
     m_books[book.getId()] = book;