diff --git a/include/name_mapper.h b/include/name_mapper.h index cba4bbdc8..4247c5c3c 100644 --- a/include/name_mapper.h +++ b/include/name_mapper.h @@ -56,10 +56,10 @@ class HumanReadableNameMapper : public NameMapper { virtual std::string getIdForName(const std::string& name) const; }; -class NameMapperProxy : public NameMapper { +class UpdatableNameMapper : public NameMapper { typedef std::shared_ptr NameMapperHandle; public: - NameMapperProxy(Library& library, bool withAlias); + UpdatableNameMapper(Library& library, bool withAlias); virtual std::string getNameForId(const std::string& id) const; virtual std::string getIdForName(const std::string& name) const; diff --git a/src/name_mapper.cpp b/src/name_mapper.cpp index eb82e873d..dccf40c9b 100644 --- a/src/name_mapper.cpp +++ b/src/name_mapper.cpp @@ -60,44 +60,44 @@ std::string HumanReadableNameMapper::getIdForName(const std::string& name) const } //////////////////////////////////////////////////////////////////////////////// -// NameMapperProxy +// UpdatableNameMapper //////////////////////////////////////////////////////////////////////////////// -NameMapperProxy::NameMapperProxy(Library& lib, bool withAlias) +UpdatableNameMapper::UpdatableNameMapper(Library& lib, bool withAlias) : library(lib) , withAlias(withAlias) { update(); } -void NameMapperProxy::update() +void UpdatableNameMapper::update() { const auto newNameMapper = new HumanReadableNameMapper(library, withAlias); std::lock_guard lock(mutex); nameMapper.reset(newNameMapper); } -NameMapperProxy::NameMapperHandle -NameMapperProxy::currentNameMapper() const +UpdatableNameMapper::NameMapperHandle +UpdatableNameMapper::currentNameMapper() const { // Return a copy of the handle to the current NameMapper object. It will - // ensure that the object survives any call to NameMapperProxy::update() + // ensure that the object survives any call to UpdatableNameMapper::update() // made before the completion of any pending operation on that object. std::lock_guard lock(mutex); return nameMapper; } -std::string NameMapperProxy::getNameForId(const std::string& id) const +std::string UpdatableNameMapper::getNameForId(const std::string& id) const { // Ensure that the current nameMapper object survives a concurrent call - // to NameMapperProxy::update() + // to UpdatableNameMapper::update() return currentNameMapper()->getNameForId(id); } -std::string NameMapperProxy::getIdForName(const std::string& name) const +std::string UpdatableNameMapper::getIdForName(const std::string& name) const { // Ensure that the current nameMapper object survives a concurrent call - // to NameMapperProxy::update() + // to UpdatableNameMapper::update() return currentNameMapper()->getIdForName(name); } diff --git a/test/name_mapper.cpp b/test/name_mapper.cpp index 7410e28ac..2a24f329b 100644 --- a/test/name_mapper.cpp +++ b/test/name_mapper.cpp @@ -103,10 +103,10 @@ TEST_F(NameMapperTest, HumanReadableNameMapperWithAliases) EXPECT_EQ("04-2021-10", nm.getIdForName("zero_four")); } -TEST_F(NameMapperTest, NameMapperProxyWithoutAliases) +TEST_F(NameMapperTest, UpdatableNameMapperWithoutAliases) { CapturedStderr stderror; - kiwix::NameMapperProxy nm(lib, false); + kiwix::UpdatableNameMapper nm(lib, false); EXPECT_EQ("", std::string(stderror)); checkUnaliasedEntriesInNameMapper(nm); @@ -119,10 +119,10 @@ TEST_F(NameMapperTest, NameMapperProxyWithoutAliases) EXPECT_THROW(nm.getIdForName("zero_four"), std::out_of_range); } -TEST_F(NameMapperTest, NameMapperProxyWithAliases) +TEST_F(NameMapperTest, UpdatableNameMapperWithAliases) { CapturedStderr stderror; - kiwix::NameMapperProxy nm(lib, true); + kiwix::UpdatableNameMapper nm(lib, true); EXPECT_EQ( "Path collision: /data/zero_four_2021-10.zim and" " /data/zero_four_2021-11.zim can't share the same URL path 'zero_four'."