Merge pull request #783 from kiwix/windows_fix

This commit is contained in:
Matthieu Gautier 2022-06-10 15:34:05 +02:00 committed by GitHub
commit 3bbbd1b15d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions

View File

@ -282,7 +282,7 @@ std::shared_ptr<Reader> Library::getReaderById(const std::string& id)
{ {
auto archive = getArchiveById(id); auto archive = getArchiveById(id);
if(archive) { if(archive) {
return std::make_shared<Reader>(archive); return std::shared_ptr<Reader>(new Reader(archive, true));
} else { } else {
return nullptr; return nullptr;
} }

View File

@ -81,15 +81,15 @@ TEST(CacheTest, DropValue) {
TEST(CacheTest1, KeepsAllValuesWithinCapacity) { TEST(CacheTest1, KeepsAllValuesWithinCapacity) {
kiwix::lru_cache<int, int> cache_lru(TEST2_CACHE_CAPACITY); kiwix::lru_cache<int, int> cache_lru(TEST2_CACHE_CAPACITY);
for (uint i = 0; i < NUM_OF_TEST2_RECORDS; ++i) { for (unsigned int i = 0; i < NUM_OF_TEST2_RECORDS; ++i) {
cache_lru.put(i, i); cache_lru.put(i, i);
} }
for (uint i = 0; i < NUM_OF_TEST2_RECORDS - TEST2_CACHE_CAPACITY; ++i) { for (unsigned int i = 0; i < NUM_OF_TEST2_RECORDS - TEST2_CACHE_CAPACITY; ++i) {
EXPECT_FALSE(cache_lru.exists(i)); EXPECT_FALSE(cache_lru.exists(i));
} }
for (uint i = NUM_OF_TEST2_RECORDS - TEST2_CACHE_CAPACITY; i < NUM_OF_TEST2_RECORDS; ++i) { for (unsigned int i = NUM_OF_TEST2_RECORDS - TEST2_CACHE_CAPACITY; i < NUM_OF_TEST2_RECORDS; ++i) {
EXPECT_TRUE(cache_lru.exists(i)); EXPECT_TRUE(cache_lru.exists(i));
EXPECT_EQ((int)i, cache_lru.get(i)); EXPECT_EQ((int)i, cache_lru.get(i));
} }