+ remove a few function attribute references

src/common/kiwix/cluceneIndexer.cpp

@@ -26,7 +26,7 @@ namespace kiwix {
   CluceneIndexer::CluceneIndexer() {
   }
 
-  void CluceneIndexer::indexingPrelude(const string &indexPath) {
+  void CluceneIndexer::indexingPrelude(const string indexPath) {
     this->dir = FSDirectory::getDirectory(indexPath.c_str(), true);
     this->writer = new IndexWriter(this->dir, &analyzer, true);
     this->writer->setUseCompoundFile(false);

src/common/kiwix/cluceneIndexer.h

@@ -43,7 +43,7 @@ namespace kiwix {
     CluceneIndexer();
     
   protected:
-    void indexingPrelude(const string &indexPath);
+    void indexingPrelude(const string indexPath);
     void index(const string &url, 
 	       const string &title, 
 	       const string &unaccentedTitle,

src/common/kiwix/indexer.cpp

@@ -342,7 +342,7 @@ namespace kiwix {
 
   /* ZIM & Index methods */
   void Indexer::setZimPath(const string path) {
-    pthread_mutex_lock(&zimPathMutex); 
+    pthread_mutex_lock(&zimPathMutex);
     this->zimPath = path;
     pthread_mutex_unlock(&zimPathMutex); 
   }
@@ -394,7 +394,7 @@ namespace kiwix {
   }
 
   /* Manage */
-  bool Indexer::start(const string &zimPath, const string &indexPath) {
+  bool Indexer::start(const string zimPath, const string indexPath) {
     this->setProgression(0);
     this->setZimPath(zimPath);
     this->setIndexPath(indexPath);

src/common/kiwix/indexer.h

@@ -61,7 +61,7 @@ namespace kiwix {
     
   public:
     Indexer();
-    bool start(const string &zimPath, const string &indexPath);
+    bool start(const string zimPath, const string indexPath);
     bool stop();
     bool isRunning();
     unsigned int getProgression();
@@ -132,7 +132,7 @@ namespace kiwix {
     string getIndexPath();
 
   protected:
-    virtual void indexingPrelude(const string &indexPath) = 0;
+    virtual void indexingPrelude(const string indexPath) = 0;
     virtual void index(const string &url, 
 		       const string &title, 
 		       const string &unaccentedTitle,

src/common/kiwix/reader.cpp

@@ -39,9 +39,9 @@ void unescapeUrl(string &url) {
 namespace kiwix {
 
   /* Constructor */
-  Reader::Reader(const string &zimFilePath) 
+  Reader::Reader(const string zimFilePath) 
     : zimFileHandler(NULL) {
-    
+
     this->zimFileHandler = new zim::File(zimFilePath);
     
     if (this->zimFileHandler != NULL) {

src/common/kiwix/reader.h

@@ -38,7 +38,7 @@ namespace kiwix {
   class Reader {
     
   public:
-    Reader(const string &zimFilePath);
+    Reader(const string zimFilePath);
     ~Reader();
 
     void reset();

src/common/kiwix/xapianIndexer.cpp

@@ -41,7 +41,7 @@ namespace kiwix {
     */
   }
   
-  void XapianIndexer::indexingPrelude(const string &indexPath) {
+  void XapianIndexer::indexingPrelude(const string indexPath) {
     this->writableDatabase = Xapian::WritableDatabase(indexPath, Xapian::DB_CREATE_OR_OVERWRITE);
     this->writableDatabase.begin_transaction(true);
   }

src/common/kiwix/xapianIndexer.h

@@ -33,7 +33,7 @@ namespace kiwix {
     XapianIndexer();
     
   protected:
-    void indexingPrelude(const string &indexPath);
+    void indexingPrelude(const string indexPath);
     void index(const string &url, 
 	       const string &title, 
 	       const string &unaccentedTitle,