smallsolar
/
libkiwix
mirror of https://github.com/kiwix/libkiwix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove default value for book pointer of `readBookFromPath`. 

This is a nonsense to accept NULL pointer here.
This commit is contained in:
Matthieu Gautier 2018-09-06 18:24:44 +02:00
parent 7804bf2276
commit 5128861136
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/manager.h
View File

@ -203,7 +203,7 @@ class Manager
protected: protected:
kiwix::Library* library; kiwix::Library* library;
bool readBookFromPath(const std::string& path, Book* book = NULL); bool readBookFromPath(const std::string& path, Book* book);
bool parseXmlDom(const pugi::xml_document& doc, bool parseXmlDom(const pugi::xml_document& doc,
const bool readOnly, const bool readOnly,
const std::string& libraryPath); const std::string& libraryPath);

2
src/manager.cpp
View File

@ -55,7 +55,7 @@ bool Manager::parseXmlDom(const pugi::xml_document& doc,
|| atoi(libraryVersion.c_str()) <= atoi(KIWIX_LIBRARY_VERSION)) { || atoi(libraryVersion.c_str()) <= atoi(KIWIX_LIBRARY_VERSION)) {
ok = false; ok = false;
if (!book.getPath().empty()) { if (!book.getPath().empty()) {
ok = this->readBookFromPath(book.getPath()); ok = this->readBookFromPath(book.getPath(), &book);
} }
} }