smallsolar
/
libkiwix
mirror of https://github.com/kiwix/libkiwix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Introduce `Library::Impl::getBookCount` 

We simply introduce a `getBookCount` which is not protected by a lock.
This commit is contained in:
Matthieu Gautier 2022-04-20 10:58:30 +02:00
parent 4695f47dd2
commit 52c12b0c2f
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/library.cpp
View File

@ -75,6 +75,8 @@ struct Library::Impl
std::vector<kiwix::Bookmark> m_bookmarks; std::vector<kiwix::Bookmark> m_bookmarks;
Xapian::WritableDatabase m_bookDB; Xapian::WritableDatabase m_bookDB;
unsigned int getBookCount(const bool localBooks, const bool remoteBooks) const;
Impl(); Impl();
~Impl(); ~Impl();
@ -94,7 +96,19 @@ Library::Impl::~Impl()
Library::Impl::Impl(Library::Impl&& ) = default; Library::Impl::Impl(Library::Impl&& ) = default;
Library::Impl& Library::Impl::operator=(Library::Impl&& ) = default; Library::Impl& Library::Impl::operator=(Library::Impl&& ) = default;
unsigned int
Library::Impl::getBookCount(const bool localBooks, const bool remoteBooks) const
{
unsigned int result = 0;
for (auto& pair: m_books) {
auto& book = pair.second;
if ((!book.getPath().empty() && localBooks)
|| (book.getPath().empty() && remoteBooks)) {
result++;
}
}
return result;
}
/* Constructor */ /* Constructor */
Library::Library() Library::Library()
@ -263,15 +277,7 @@ unsigned int Library::getBookCount(const bool localBooks,
const bool remoteBooks) const const bool remoteBooks) const
{ {
std::lock_guard<std::mutex> lock(m_mutex); std::lock_guard<std::mutex> lock(m_mutex);
unsigned int result = 0; return mp_impl->getBookCount(localBooks, remoteBooks);
for (auto& pair: mp_impl->m_books) {
auto& book = pair.second;
if ((!book.getPath().empty() && localBooks)
|| (book.getPath().empty() && remoteBooks)) {
result++;
}
}
return result;
} }
bool Library::writeToFile(const std::string& path) const bool Library::writeToFile(const std::string& path) const