From e4595f357d15884674703b5a20284d830a844e50 Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Fri, 26 May 2023 13:54:52 +0200 Subject: [PATCH 1/5] Use Ubuntu Focal as CI base image --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 026ec9225..1d3316cad 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -54,19 +54,19 @@ jobs: include: - name: native_static target: native_static - image_variant: bionic + image_variant: focal lib_postfix: '/x86_64-linux-gnu' - name: native_dyn target: native_dyn - image_variant: bionic + image_variant: focal lib_postfix: '/x86_64-linux-gnu' - name: android_arm target: android_arm - image_variant: bionic + image_variant: focal lib_postfix: '/arm-linux-androideabi' - name: android_arm64 target: android_arm64 - image_variant: bionic + image_variant: focal lib_postfix: '/aarch64-linux-android' - name: win32_static target: win32_static From d8f02ac2255fc12fd9644c491654a041416052a9 Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Fri, 26 May 2023 14:00:46 +0200 Subject: [PATCH 2/5] Uses actions/checkout --- .github/workflows/ci.yml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1d3316cad..932955f91 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -83,17 +83,7 @@ jobs: image: "ghcr.io/kiwix/kiwix-build_ci_${{matrix.image_variant}}:36" steps: - name: Checkout code - shell: python - run: | - from subprocess import check_call - from os import environ - command = [ - 'git', 'clone', - 'https://github.com/${{github.repository}}', - '--depth=1', - '--branch', '${{ github.head_ref || github.ref_name }}' - ] - check_call(command, cwd=environ['HOME']) + uses: actions/checkout@v3 - name: Install deps shell: bash run: | From ae605dc26d49de577b5d329a680d99a01fc8992b Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Fri, 26 May 2023 14:05:31 +0200 Subject: [PATCH 3/5] Use latest version 27 of docker base image --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 932955f91..d9b05e9c4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -80,7 +80,7 @@ jobs: HOME: /home/runner runs-on: ubuntu-latest container: - image: "ghcr.io/kiwix/kiwix-build_ci_${{matrix.image_variant}}:36" + image: "ghcr.io/kiwix/kiwix-build_ci_${{matrix.image_variant}}:37" steps: - name: Checkout code uses: actions/checkout@v3 From 0afa5e569ceb40692512a1d204afa0ed800e3314 Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Fri, 26 May 2023 14:07:03 +0200 Subject: [PATCH 4/5] Ubuntu 20.04 & macos 11 as OS in CI --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d9b05e9c4..aa479bac3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ on: jobs: macOS: - runs-on: macos-12 + runs-on: macos-11 env: HOME: /Users/runner steps: @@ -78,7 +78,7 @@ jobs: lib_postfix: '64' env: HOME: /home/runner - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 container: image: "ghcr.io/kiwix/kiwix-build_ci_${{matrix.image_variant}}:37" steps: From 2d58142c58e6795ecf33ada6dce158a29b024a52 Mon Sep 17 00:00:00 2001 From: Emmanuel Engelhart Date: Fri, 26 May 2023 14:09:02 +0200 Subject: [PATCH 5/5] No need anymore to change directory --- .github/workflows/ci.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index aa479bac3..ec3df45d6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -106,7 +106,6 @@ jobs: if [[ "${{matrix.target}}" =~ android_.* ]]; then MESON_OPTION="$MESON_OPTION -Dstatic-linkage=true" fi - cd $HOME/libkiwix meson . build ${MESON_OPTION} cd build ninja @@ -117,7 +116,7 @@ jobs: if: startsWith(matrix.target, 'native_') shell: bash run: | - cd $HOME/libkiwix/build + cd build meson test --verbose ninja coverage env: