From af228bf45f8f35340b4e2b565537bc210006b0ec Mon Sep 17 00:00:00 2001
From: Veloman Yunkan <veloman.yunkan@gmail.com>
Date: Tue, 5 Dec 2023 17:13:28 +0400
Subject: [PATCH] Dropped cookies from RequestContext

This should have been done in PR#997 in order to better guarantee
a lasting solution to issue#995.
---
 src/server/request_context.cpp | 9 ---------
 src/server/request_context.h   | 2 --
 2 files changed, 11 deletions(-)

diff --git a/src/server/request_context.cpp b/src/server/request_context.cpp
index 91ff7a72d..2b5b6fd4c 100644
--- a/src/server/request_context.cpp
+++ b/src/server/request_context.cpp
@@ -66,7 +66,6 @@ RequestContext::RequestContext(struct MHD_Connection* connection,
 {
   MHD_get_connection_values(connection, MHD_HEADER_KIND, &RequestContext::fill_header, this);
   MHD_get_connection_values(connection, MHD_GET_ARGUMENT_KIND, &RequestContext::fill_argument, this);
-  MHD_get_connection_values(connection, MHD_COOKIE_KIND, &RequestContext::fill_cookie, this);
 
   try {
     acceptEncodingGzip =
@@ -107,14 +106,6 @@ MHD_Result RequestContext::fill_argument(void *__this, enum MHD_ValueKind kind,
   return MHD_YES;
 }
 
-MHD_Result RequestContext::fill_cookie(void *__this, enum MHD_ValueKind kind,
-                                         const char *key, const char* value)
-{
-  RequestContext *_this = static_cast<RequestContext*>(__this);
-  _this->cookies[key] = value == nullptr ? "" : value;
-  return MHD_YES;
-}
-
 void RequestContext::print_debug_info() const {
   printf("method    : %s (%d)\n", method==RequestMethod::GET ? "GET" :
                                   method==RequestMethod::POST ? "POST" :
diff --git a/src/server/request_context.h b/src/server/request_context.h
index 80d67ea6f..0393dce77 100644
--- a/src/server/request_context.h
+++ b/src/server/request_context.h
@@ -145,7 +145,6 @@ class RequestContext {
     ByteRange byteRange_;
     std::map<std::string, std::string> headers;
     std::map<std::string, std::vector<std::string>> arguments;
-    std::map<std::string, std::string> cookies;
     std::string queryString;
     UserLanguage userlang;
 
@@ -153,7 +152,6 @@ class RequestContext {
     UserLanguage determine_user_language() const;
 
     static MHD_Result fill_header(void *, enum MHD_ValueKind, const char*, const char*);
-    static MHD_Result fill_cookie(void *, enum MHD_ValueKind, const char*, const char*);
     static MHD_Result fill_argument(void *, enum MHD_ValueKind, const char*, const char*);
 };