smallsolar
/
libkiwix
mirror of https://github.com/kiwix/libkiwix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Added a couple of notes on data consistency

This commit is contained in:
Veloman Yunkan 2021-10-31 16:50:38 +04:00
parent 9f0db6b7fa
commit c129952605
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/book.cpp
View File

@ -104,6 +104,7 @@ void Book::update(const zim::Archive& archive) {
Illustration& favicon = getMutableDefaultIllustration();
getArchiveFavicon(archive, 48, favicon.data, favicon.mimeType);
// XXX: isn't favicon.url neglected here?
}
#define ATTR(name) node.attribute(name).value()
@ -182,6 +183,7 @@ void Book::updateFromOpds(const pugi::xml_node& node, const std::string& urlHost
}
if (rel == "http://opds-spec.org/image/thumbnail") {
Illustration& favicon = getMutableDefaultIllustration();
// XXX: shouldn't favicon.data be cleared()?
favicon.url = urlHost + linkNode.attribute("href").value();
favicon.mimeType = linkNode.attribute("type").value();
}