Matthieu Gautier
6d2f227c42
Merge pull request #486 from kiwix/fix_for_issue462
2021-04-12 15:18:57 +02:00
Veloman Yunkan
0c7d19ab45
Testing of Manager.readXml()
2021-04-12 15:14:12 +02:00
Veloman Yunkan
b54215f146
Manager::readOpds() doesn't modify its input
2021-04-12 15:14:12 +02:00
Veloman Yunkan
9033f2f28e
Manager::readXml() doesn't modify its input
2021-04-12 15:14:12 +02:00
Matthieu Gautier
5c289abd0e
Merge pull request #485 from kiwix/fix_for_issue478
2021-04-12 15:05:13 +02:00
Veloman Yunkan
ec9186b174
Library::removeBookById() updates the search DB
...
This fix makes the `XmlLibraryTest.removeBookByIdUpdatesTheSearchDB`
unit-test pass.
2021-04-09 17:06:45 +04:00
Veloman Yunkan
aaaa5a637e
Library::filter() doesn't create empty books
...
This changes how the `XmlLibraryTest.removeBookByIdUpdatesTheSearchDB`
unit-test fails.
2021-04-09 17:06:45 +04:00
Veloman Yunkan
49940a30d0
XmlLibraryTest.removeBookByIdUpdatesTheSearchDB
...
The new unit-test fails with a reason not expected before it was
written. The `Library::filter()` operation returns a correct result
after the call to `removeBookById()` (this was a surprise!) but it has
a side-effect of re-adding an empty book with the id still surviving
in the search DB (the emptiness of this re-created book doesn't allow
it to pass the other filtering criteria, which explains why the result
of `Library::filter()` is correct). Had to add a special check
to the new unit-test against that hidden side-effect of
`Library::removeBookById()` + `Library::filter()` combination.
2021-04-09 17:06:45 +04:00
Veloman Yunkan
24ed96a38c
Library.removeBookById() drops the reader too
...
This fix makes the `XmlLibraryTest.removeBookByIdDropsTheReader`
unit-test pass.
2021-04-09 17:05:56 +04:00
Veloman Yunkan
ccdc316217
Two unit-tests for Library::removeBookById
...
The `XmlLibraryTest.removeBookByIdDropsTheReader` unit-test fails,
demonstrating a bug in `kiwix::Library::removeBookById()`.
2021-04-09 16:59:55 +04:00
Matthieu Gautier
ba44033273
Merge pull request #464 from MananJethwani/issue/kiwix-tools/205
...
adding kind and path attributes to suggest response object and using it in autocomplete
2021-04-07 18:08:29 +02:00
Manan Jethwani
5cb276a933
adding kind and path attributes to suggest response object and using it in autocomplete
2021-04-07 21:04:33 +05:30
Matthieu Gautier
e4be97a032
Merge pull request #470 from kiwix/xapian_should_not_be_exposed
2021-04-07 16:55:24 +02:00
Veloman Yunkan
aa2a031ba4
Xapian headers are not exposed through libkiwix
2021-04-07 18:24:33 +04:00
Kelson
803cb1c2c5
Merge pull request #476 from MananJethwani/correcting#474
...
changed method of injecting root link
2021-03-24 10:20:54 +01:00
Manan Jethwani
7872734f44
changed method of injecting root link
2021-03-24 14:17:58 +05:30
Kelson
d061697de7
Merge pull request #474 from MananJethwani/issue/473
...
injecting root link directly and renamed head_part to head_taskbar
2021-03-24 09:24:42 +01:00
Manan Jethwani
c557bb271b
injecting root link directly and renamed head_part to head_taskbar
2021-03-24 02:10:16 +05:30
Kelson
1f45c42c32
Merge pull request #472 from MananJethwani/issue/407
...
added root functionality for block external link feature
2021-03-23 10:54:22 +01:00
Manan Jethwani
93264f7409
added root functionality for block external link feature
2021-03-23 03:17:14 +05:30
Matthieu Gautier
baed447dd3
Merge pull request #460 from kiwix/xapian_based_catalog_search
2021-03-17 14:45:56 +01:00
Veloman Yunkan
20b487da8d
Added Xapian as direct dependency
2021-03-17 14:32:03 +01:00
Veloman Yunkan
e214efecd4
Language code conversion via ICU
...
Language code is converted from ISO 639-3 to ISO 639 (which is
understood by Xapian) via ICU. The previous approach via an explicit
map had its advantages since Xapian has more than one stemmer
implementations for some languages (selectable via Xapian-specific
identifiers). This commit relies on the defaults associated with the
ISO 639 language codes.
2021-03-17 14:32:03 +01:00
Veloman Yunkan
09233bf4f3
Support for partial queries in catalog search
...
The search text in the catalog query is interpreted as partial by
default, but partial query mode can be disabled in C++. The latter
possibility is not exposed via the /catalog/search kiwix-serve endpoint,
though.
2021-03-17 14:32:03 +01:00
Veloman Yunkan
47c67a4202
LibraryServerTest.catalog_search_with_word_exclusion
2021-03-17 14:32:03 +01:00
Veloman Yunkan
6b600a18eb
LibraryServerTest.catalog_prefix_search
2021-03-17 14:32:03 +01:00
Veloman Yunkan
9e887cadf1
Added some diversity to test/data/library.xml
2021-03-17 14:32:03 +01:00
Veloman Yunkan
a599fb3892
Initial version of Xapian-based catalog search
2021-03-17 14:32:03 +01:00
Veloman Yunkan
a17fc0ef2d
Library::getBooksByTitleOrDescription()
2021-03-17 14:32:03 +01:00
Veloman Yunkan
db06b2c7ca
Library::BookIdCollection typedef
2021-03-17 14:32:03 +01:00
Veloman Yunkan
a20f9e2ce1
Library::filter() works in two stages
...
1. Get the subset of books matching the q (title/description) parameter
of the search
2. Filter out books not matching the other parameters of the search.
Stage 1. currently works in the old way, but will be replaced by Xapian
based search in subsequent commits.
2021-03-17 14:32:03 +01:00
Kelson
f7c867f8a7
Merge pull request #459 from kiwix/opds_category_support
...
Support for book categories in OPDS feed
2021-03-17 12:37:16 +01:00
Veloman Yunkan
b7b0bdbdd8
Both Book::update() methods update the category
2021-03-17 14:10:57 +04:00
Veloman Yunkan
a870e05621
Slight enhancement of BookTest.updateTest
2021-03-17 14:10:57 +04:00
Veloman Yunkan
4abc4f8518
Support for book category attribute in library.xml
2021-03-17 14:10:57 +04:00
Veloman Yunkan
6b2067c236
Reading category element from OPDS stream
2021-03-17 14:10:57 +04:00
Veloman Yunkan
e55bf514e8
Dedicated 'category' parameter in catalog search
2021-03-17 14:10:57 +04:00
Veloman Yunkan
80d4f7e349
Extracted InternalServer::search_catalog()
2021-03-17 14:10:57 +04:00
Veloman Yunkan
f270724b1f
Testing of a library entry without a category
2021-03-17 14:10:44 +04:00
Veloman Yunkan
58186ffb26
kiwix::Book::getCategory()
2021-03-17 14:09:48 +04:00
Veloman Yunkan
6d43fd065f
Less boilerplate in LibraryServerTest unit-tests
2021-03-17 14:02:27 +04:00
Veloman Yunkan
071d2bedd3
LibraryServerTest.catalog_search_by_text
2021-03-17 14:02:27 +04:00
Veloman Yunkan
0b1740e6c5
LibraryServerTest.catalog_search_by_tag
2021-03-17 14:02:27 +04:00
Veloman Yunkan
9913f748e2
LibraryServerTest.catalog_searchdescription_xml
2021-03-17 14:02:27 +04:00
Veloman Yunkan
c5c40cb189
New unit-test LibraryServerTest.catalog_root_xml
2021-03-17 14:02:27 +04:00
Veloman Yunkan
ae32ff40c0
Dropped an extra colon from book <updated> dates
2021-03-17 14:02:27 +04:00
Veloman Yunkan
26331b401e
Fixed the month in OPDS feed <updated> date
...
`tm::tm_mon` varies in the [0, 11] range.
2021-03-17 14:02:27 +04:00
Matthieu Gautier
0f368791a2
Merge pull request #461 from MananJethwani/issue/444
2021-03-15 16:57:10 +01:00
Manan Jethwani
fb26f6b9c5
moved autocomplete from head_part.html to taskbar.js
2021-03-15 18:10:10 +05:30
Matthieu Gautier
32643fbd94
Merge pull request #463 from soumyankar/master
...
Change Mustache-3.0 to Mustache-4.1
2021-03-15 11:38:57 +01:00