Matthieu Gautier
d9124ed40b
Set the book title only if we have a library.
2022-02-25 15:46:13 +01:00
Matthieu Gautier
921671eb4d
Do not use ostringstream to convert the uuid into string.
...
`zim::Uuid` already have a string convertion operator. Let's use it.
2022-02-25 15:46:13 +01:00
Matthieu Gautier
ec18eb40ea
Readd a `SearchRenderer` constructor without `Library` argument.
...
Adding the library argument breaks the API. It is better to add
another constructor to not have to create another major version.
2022-02-25 15:46:13 +01:00
Matthieu Gautier
a11abcf480
Merge pull request #715 from kiwix/opds_dc_issued
2022-02-23 14:39:14 +01:00
Veloman Yunkan
ae2d7d20dc
Handling of <dc:issued> in OPDS import
2022-02-23 14:20:49 +01:00
Veloman Yunkan
42ee14c8f5
New unit-test LibraryOpdsImportTest.allInOne
2022-02-21 23:20:35 +04:00
Veloman Yunkan
afb556bf64
Added <dc:issued> field to OPDS entries
2022-02-19 11:35:44 +04:00
Kelson
5c38300504
Merge pull request #713 from kiwix/use-local-include
...
Fix library.h include
2022-02-17 13:08:56 +01:00
Emmanuel Engelhart
cb2226c11f
Fix library.h include
2022-02-17 10:56:46 +01:00
Matthieu Gautier
4cce4dce0b
Merge pull request #710 from kiwix/unittests_for_404_html_page
2022-02-16 14:38:23 +01:00
Veloman Yunkan
34d069e61f
Two more 404 error tests for the /raw endpoint
2022-02-16 14:25:43 +01:00
Veloman Yunkan
7a6562395a
Testing of /ROOT/zimfile/invalid-article
2022-02-16 14:23:11 +01:00
Veloman Yunkan
92f9ee9280
Preparing to test archive dependent 404 responses
2022-02-16 14:23:11 +01:00
Veloman Yunkan
ae2d9b234f
More test points in ServerTest.404WithBodyTesting
2022-02-16 14:23:11 +01:00
Veloman Yunkan
0ba452aece
New unit-test ServerTest.404WithBodyTesting
...
The `ServerTest.RandomOnNonExistentBook` unit test was replaced with a
more general one testing multiple 404 scenarios where the content of the
body is checked too.
2022-02-16 14:23:11 +01:00
Veloman Yunkan
5f4256b900
Enter helper function makeExpected404Response()
2022-02-16 14:23:11 +01:00
Veloman Yunkan
a34dc725f9
ServerTest.RandomOnNonExistentBook
...
This test was introduced with the purpose of testing the error message
in the 404 page returned by /random for a non-existent book. The actual
expected output currently present in this new unit-test is too much for
that purpose and may become a maintenance burden if more tests of that
kind are added.
2022-02-16 14:23:11 +01:00
Kelson
892db07a2d
Merge pull request #705 from thavelick/book_title_in_search_results
...
Add book titles to search results
2022-02-16 12:59:38 +01:00
Tristan Havelick
58be502f3f
add book titles to search results
2022-02-16 12:50:18 +01:00
Matthieu Gautier
62ba2f4861
Merge pull request #709 from kiwix/unittest_for_suggestions
2022-02-16 11:30:26 +01:00
Veloman Yunkan
c782cc718a
Workaround for Packages/build-deb CI failures
...
Packages/build-deb CI flows failed on ubuntu-bionic and ubuntu-focal
with the following mismatch in the ServerTest.suggestions unit-test:
```
[ RUN ] ServerTest.suggestions
../test/server.cpp:715: Failure
Expected equality of these values:
r->body
Which is: ...
removeEOLWhitespaceMarkers(expectedResponse)
Which is: ...
With diff:
@@ -2,5 +2,5 @@
{
\"value\" : \"Ray (movie)\",
- \"label\" : \"Ray (<b>movie</b>...\",
+ \"label\" : \"Ray (<b>movie</b>)\",
\"kind\" : \"path\"
, \"path\" : \"A/Ray_(movie)\"
Test context:
url: /ROOT/suggest?content=zimfile&term=movie
```
For some reason (probably, a bug), the implementation of
`Xapian::MSet::snippet()` on those platforms decided that a single closing
parenthesis is more than is appropriate for inclusion in the snippet and
replaced it with a (longer) ellipsis.
Taking advantage of the necessity to work around that bug, the
ServerTest.suggestions's functional coverage was enhanced - the
problematic test point was replaced with a new one using a phrase
instead of a single term.
2022-02-14 18:17:48 +04:00
Veloman Yunkan
9a6aef4dba
Moved/renamed LibraryServerTest.suggestions_in_range
2022-02-11 16:06:52 +04:00
Veloman Yunkan
943cbbf6ce
New unit test ServerTest.suggestions
2022-02-11 16:06:52 +04:00
Kelson
ec94d9bfd9
Merge pull request #703 from kiwix/fix-mipsel-cross-compilation
...
Use "host_machine", not "target_machine" for cross-compilation
2022-02-09 07:09:56 +01:00
Emmanuel Engelhart
f2088d7fe0
Use "host_machine", not "target_machine" for cross-compilation
...
Read https://mesonbuild.com/Cross-compilation.html for all the rationals.
2022-02-09 07:02:14 +01:00
Kelson
19dd068e5a
Merge pull request #706 from kiwix/langFix
...
Only add value in language object if value entry node is 'language'
2022-02-08 21:31:58 +01:00
Nikhil Tanwar
d56e56293b
Only add value in language object if value entry node is 'language'
2022-02-08 19:03:35 +05:30
Kelson
dc4f9a4939
Merge pull request #700 from kiwix/ipLimit
...
Add method to change MHD_OPTION_PER_IP_CONNECTION_LIMIT
2022-02-06 15:12:32 +01:00
Nikhil Tanwar
261adf0ef9
Add method to change MHD_OPTION_PER_IP_CONNECTION_LIMIT
...
Adds new method setIpConnectionLimit() to server.
Default is 0 (infinite)
2022-02-05 18:31:42 +05:30
Matthieu Gautier
ce24b1fa5f
Merge pull request #699 from kiwix/br_10.0.1
2022-02-02 16:06:18 +01:00
Matthieu Gautier
9193719c8f
New version 10.0.1
2022-02-02 15:55:40 +01:00
Kelson
d0d253beed
Merge pull request #698 from kiwix/legoktm-patch-1
...
PPA: Remove Ubuntu Hirsute, EOL
2022-02-01 08:27:50 +01:00
Kunal Mehta
cf95d513d6
PPA: Remove Ubuntu Hirsute, EOL
2022-01-31 23:13:00 -08:00
Kelson
e72c0b75f6
Merge pull request #697 from kiwix/titleWithLanguage
...
Add title with full language name
2022-01-29 10:01:20 +01:00
Nikhil Tanwar
4d996584fa
Add title with full language name
...
This adds title and aria-label attributes with value as the language of book
Provides tooltip on language badges
2022-01-28 22:53:38 +05:30
Kelson
dd3338c2d0
Merge pull request #694 from kiwix/kelson42-patch-1
...
Fix macOS CI
2022-01-28 10:45:42 +01:00
Kelson
b19eb1ea61
Stop publishing code coverage for macOS
...
No reason to upload code coverage twice
2022-01-27 21:23:16 +01:00
Kelson
6d14639f77
Use Python 3.10 to fix macOS CI
2022-01-27 21:22:19 +01:00
Kelson
89e3a57a05
Merge pull request #693 from kiwix/non-minified-isotope
...
Add non-minified version of isotope.pkgd.js
2022-01-27 20:02:28 +01:00
Kunal Mehta
b94e4b7e3b
Add non-minified version of isotope.pkgd.js
...
Debian wants to have the source files for minified scripts. Otherwise
same rationale as #368 which was for jquery-ui.
I downloaded this from <https://unpkg.com/isotope-layout@3.0.6/dist/isotope.pkgd.js >.
2022-01-27 00:11:04 -08:00
Kelson
68465079f0
Merge pull request #691 from kiwix/downloadLinkFix
...
Add span in querySelector
2022-01-24 15:43:10 +01:00
Nikhil Tanwar
f6309bb4c8
Add span in querySelector
...
Earlier querySelector for download button was returning a div, on which we called the getAttribute function hence returning null
This now returns a <span> element which returns the correct link with getAttribute
2022-01-24 19:23:26 +05:30
Kelson
45e9b76b19
Merge pull request #689 from kiwix/slightly-better-fix-685
...
Fix title='_' case too #685
2022-01-24 09:05:35 +01:00
Emmanuel Engelhart
5a9dbf85ec
Fix title='_' case too #685
2022-01-24 08:35:36 +01:00
Kelson
cd412867d9
Merge pull request #688 from kiwix/legoktm-patch-1
2022-01-24 06:42:52 +01:00
Kunal Mehta
01edd830bc
PPA: Fix libzim-dev dependency
...
Our libzim packages are "7.2.0~focal" but the ~ means that "7.2.0" is greater than
"7.2.0~focal" so the dependency can't be satisfied. Depending on "7.2.0~" will
allow "7.2.0~focal" to satisfy the dependency.
2022-01-23 20:30:23 -08:00
Kelson
ceb46f1069
Merge pull request #687 from kiwix/langCatBoxFill
...
Add undefined check for humanFriendlyTitle
2022-01-23 20:39:48 +01:00
Nikhil Tanwar
270773d6ba
Add undefined check for humanFriendlyTitle
...
humanFriendlyTitle() now returns an empty string if title is undefined
which is handled in loadAndDisplayOptions()
2022-01-23 20:33:46 +01:00
Kelson
234606b170
Merge pull request #686 from kiwix/catalog_search_with_zero_count
2022-01-22 08:47:06 +01:00
Veloman Yunkan
b8328a78f6
/catalog/search?count=0 returns all entries
2022-01-21 19:31:46 +04:00