Kelson
38fc187303
Merge pull request #678 from kiwix/depends_libzim_7.1.0
...
Needs libzim 7.1.0 getMetadataItem()
2022-01-16 09:59:54 +01:00
Emmanuel Engelhart
2dc8fc9ab3
Needs libzim 7.1.0 getMetadataItem()
2022-01-15 15:57:04 +01:00
Kelson
60b4be2286
Merge pull request #676 from kiwix/customURLfix
...
Remove {root} from book item's link in library
2022-01-14 16:31:16 +01:00
Nikhil Tanwar
a8a68c54a2
Remove {root} from book item's link in library
...
The OPDS stream now provides full URL, including the custom root
Appending {root} duplicates the custom root, when given resulting in a broken link
2022-01-14 16:23:52 +01:00
Kelson
367e5d2636
Merge pull request #675 from kiwix/fix_android
...
Revert removing of deprecated methods used by android wrapper.
2022-01-14 16:19:14 +01:00
Matthieu Gautier
fcd865bb81
Revert removing of deprecated methods used by android wrapper.
2022-01-14 12:28:50 +01:00
Matthieu Gautier
715151d725
Merge pull request #674 from kiwix/deprecated
2022-01-13 14:32:28 +01:00
Matthieu Gautier
e5eeb08206
Remove old deprecated methods.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
ac6f91798f
Assume `SuggestionItem` has a public constructor.
...
`SuggestionItem` is somehow a simple container.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
e5d26a4699
Deprecate `SearchRenderer` creation from a `Searcher`.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
3d64a9d9a9
Deprecate `Searcher` creation.
...
As the `Searcher` is now deprecated, we also remove the unit tests on it.
`Searcher` is now untested, and so it reduces the code coverage.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
fb7d9f02c8
Deprecate `Reader` creation.
...
As we `Reader` is now deprecated, we also remove the unit tests on it.
`Reader` is now untested, and so it reduces the code coverage.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
96e0d15ab4
Deprecate `Entry` creation.
...
As the `Entry` is still created by `Reader` we need a way to create a
entry without raising a deprecated warning.
To do so we create a second constructor with a dummy argument.
This second constructor is private and is not marked as deprecated so we
can use it.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
39732e2bcf
Deprecate methods on Book.
...
- `update(const Reader& reader)` is replaced by
`update(const zim::Archive& archive)`
- `getFavicon*()` is replaced by `getIllustration(48)->*`
2022-01-12 18:07:46 +01:00
Kelson
7dfafe0196
Merge pull request #673 from kiwix/urlEncode
2022-01-12 13:19:54 +01:00
Matthieu Gautier
3052d0787a
UrlEncode the `content_id`.
...
The HumanReadableId can contains special char (`&`/`=`/...)
As it is used as to create a url in the opds template,
we must url encode it.
- We don't need to encode the book id as it is a uuid, it never contains
special char.
- We don't need to encode the book url as it is read from the library and
the url must already be correctly encoded in the library.xml.
(tests modified accordingly)
2022-01-11 17:53:29 +01:00
Kelson
d4db090bb9
Merge pull request #672 from kiwix/LadakhiISO
...
Add new method for language code
2022-01-11 15:39:49 +01:00
Nikhil Tanwar
0633f68f80
Add new values from wikipedia
...
Added new values. This now covers all iso 639-1 codes from https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes
2022-01-11 15:32:06 +01:00
Nikhil Tanwar
2a5db3e7ab
Use iso6391to3.js for language tag value
...
Improves upon the previous method of truncating language to first 2 values which was showing wrong values
2022-01-11 15:31:55 +01:00
Matthieu Gautier
468a080b09
Merge pull request #669 from kiwix/remove_meta_endpoints
2022-01-10 13:44:23 +01:00
Matthieu Gautier
1705f938b5
Extend unittest to check 404 error on wrong raw endpoints.
...
Check that `/raw` endpoint behaves correctly with wrong book name or
wrong kind.
2022-01-10 13:13:27 +01:00
Matthieu Gautier
0112e6102d
Remove the meta endpoint in the server.
...
Now we have `/raw` and `catalog/v2/illustration` endpoints we don't need
to keep the meta endpoint.
2022-01-10 13:13:27 +01:00
Kelson
e4d99f0374
Merge pull request #668 from kiwix/fileExists
...
Introduce kiwix::fileReadable
2022-01-09 20:16:56 +01:00
Emmanuel Engelhart
aa50845e22
Fix small typos in comments
2022-01-09 20:05:30 +01:00
Nikhil Tanwar
3dbcbe542b
Add tests for kiwix::fileExists and kiwix::fileReadable
2022-01-10 00:18:44 +05:30
Nikhil Tanwar
854058f842
Introduce kiwix::fileReadable
...
kiwix::fileExists only checks for file existence now
kiwix::fileReadable will check if the file is readable (implicitly checking for file existence also)
2022-01-05 20:16:38 +05:30
Matthieu Gautier
c9eb3196f7
Merge pull request #646 from kiwix/raw_endpoints
2022-01-05 15:31:35 +01:00
Matthieu Gautier
dc15a9a824
Add `raw` endpoint.
...
As the name suggests it, this endpoint is not smart :
It returns the content as it is and only if it is present
(no compatibility or whatever).
The only "smart" thing is to return a redirect if the entry is a redirect.
2022-01-05 15:12:41 +01:00
Matthieu Gautier
160a74f5f8
Extend ItemResponse and ContentResponse to return raw content.
2022-01-05 15:12:41 +01:00
Matthieu Gautier
78c10346f2
Merge pull request #645 from kiwix/illustration_api
2022-01-04 14:34:00 +01:00
Matthieu Gautier
6f1799db9f
Use the new endpoint in the OPDS stream.
2022-01-04 14:16:46 +01:00
Matthieu Gautier
e108fb0e47
Add `/catalog/v2/illustration` endpoint
2022-01-04 14:16:46 +01:00
Matthieu Gautier
9482bfb95b
Add a method to get the a book illustration for a specific size.
2022-01-04 14:16:46 +01:00
Matthieu Gautier
66c40817ee
Fix the OPDS stream to handle custom ROOT prefix
...
As we render the entry's xml in a separated steps, we need to pass the
rootLocation to all the internal rendering.
Testing with and without root is not so easy.
I've simply made all server tests using a ROOT prefix.
We can assume that if the ROOT is present everywhere we need it, it will not
when we don't need. (As long as we don't hardcode "ROOT" in the server.)
2022-01-04 11:15:18 +01:00
Matthieu Gautier
22e5327dcf
Do not create a dummy illustration if library.xml doesn't contain one.
...
Fix #644
2022-01-04 11:12:32 +01:00
Kelson
d29611ed75
Merge pull request #667 from kiwix/issue603
...
Safer scroll bound detection
2022-01-03 19:16:27 +01:00
renaud gaudin
b1bc883bf5
Fixed #603 : safer scroll bound detection
...
At least on Retina Macbook Pros but most likely on other configurations,
the viewport's sizes is not exactly consistent to integer.
For instance, on a maximized Firefox, document.body.offsetHeight is 1,600.
When looking at the <html> on the inspector, I'd get 1,599.6, so **roughly** the same
but not exactly. Those inconsistencies are present on every level so being too strict
about those is probably not adequate.
This fixes #603 but allowing a 2% margin on the scroll position
to match the _end of screen_ and thus trigger the loading of additional cards.
This means that for the example above, it triggers at 1,568 instead of never reaching 1,600.
2% might be too large but it seems safe considering the potential of various resolutions
we may encounter and I don't see any side effect.
2022-01-03 14:41:19 +00:00
Kelson
a8577d7a01
Merge pull request #666 from kiwix/aria2Security
...
Make aria2 secret a random value
2022-01-03 09:46:11 +01:00
Nikhil Tanwar
8bdcb90818
Make aria2 secret a random value
...
Apps using this service will not have a default aria secret (previously 'kiwixariarpc')
2022-01-03 09:35:04 +01:00
Kelson
91a4491b74
Merge pull request #665 from kiwix/dependences_version
...
Dependences version
2022-01-02 12:31:25 +01:00
Emmanuel Engelhart
f36d8e9851
New kiwix::getVersions() and printVersions()
2022-01-02 12:22:11 +01:00
Kelson
5e1988640c
Merge pull request #664 from kiwix/missingMetadataFix
2021-12-28 20:35:16 +01:00
Nikhil Tanwar
aa3bd8560b
Add fallback image if thumbnail metadata is not available in zim
2021-12-29 00:15:34 +05:30
Nikhil Tanwar
9c047844c0
Add fallback if metadata (title, description, language, tags)
...
This provides a workaround the crash happening because of missing metadata.
Language div is set to be hidden if no language data is found
2021-12-29 00:11:57 +05:30
Matthieu Gautier
843d315b93
Merge pull request #663 from kiwix/fix_win32
2021-12-23 18:38:25 +01:00
Matthieu Gautier
f1035fa472
Fix win32 compilation.
...
WSASocket return a `INVALID_SOCKET` if something goes wrong,
not SOCKET_ERROR.
2021-12-23 18:32:43 +01:00
Kelson
6c95458f5e
Merge pull request #622 from juuz0/issue613
...
Provide HTTP URL for the server
2021-12-22 18:35:34 +01:00
Nikhil Tanwar
9554ab5db0
Make getNetworkInterfaces() and getBestPublicIp() available via tools.h
...
Remove HTTP URL helper line - should be done in kiwix-serve
Add getters at server level - getAddress and getPort
2021-12-22 22:38:16 +05:30
Nikhil Tanwar
4b563e567e
Provide HTTP URL for the server
...
Added a line to display the IP (use best if nothing is provided) along with port.
2021-12-22 22:08:25 +05:30
Matthieu Gautier
a77fae0993
Merge pull request #651 from kiwix/less_confusing_404_errors
2021-12-22 17:30:29 +01:00