smallsolar
/
libkiwix
mirror of https://github.com/kiwix/libkiwix.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
2,489 Commits 23 Branches 58 Tags 88 MiB
Commit Graph

2489 Commits

Author SHA1 Message Date
Veloman Yunkan fa7d044037 One more translation on the welcome page 
This translation has to deal with handling of plural forms which is a
tricky part of internationalization, but we are not going to complicate
things in our code and will offload the headache to translators (they
will have to invent a single message for all numbers).
 2023-02-22 17:53:23 +04:00
Veloman Yunkan d42fa22450 Translation of static text on the welcome page 
Note that i18n/test.json overgrew the non-compressible size limit, that
is why it had to move to a richer neighbourhood.
 2023-02-22 17:53:03 +04:00
Veloman Yunkan 7307a9a1b7 First translation on the welcome page 2023-02-22 17:50:22 +04:00
Kelson bf80367b5a
Merge pull request #898 from kiwix/improve-macos-ci 
Improve macOS Ci workflow
 2023-02-20 16:49:22 +01:00
Emmanuel Engelhart a04646b7b2
Simplify ninja and meson calls 2023-02-20 16:36:30 +01:00
Emmanuel Engelhart cfe3f8e3d9
Better use HTTPS in place of HTTP 2023-02-19 17:10:08 +01:00
Emmanuel Engelhart 2d0cff2dc1
Better definition of env variables 2023-02-19 17:10:04 +01:00
Emmanuel Engelhart b24157ddf9
Not necessary to specify bash, already the default 2023-02-19 16:42:37 +01:00
Emmanuel Engelhart c57b5ba1ad
Install meson using Homebrew 2023-02-19 16:36:28 +01:00
Emmanuel Engelhart fe646511d1
Python3 is already available 2023-02-19 16:29:31 +01:00
Emmanuel Engelhart cc31846152
Don't install unused packages 2023-02-19 16:22:23 +01:00
Emmanuel Engelhart cb4938c5f8
Improve a bit the readability of the workflow 2023-02-19 16:21:30 +01:00
Emmanuel Engelhart b1055e814a
Use fix macOS version in CI 2023-02-19 16:12:21 +01:00
Kelson 13951c13df
Merge pull request #895 from kiwix/better-package-ci-triggers 
Better triggers for packages builds
 2023-02-16 16:28:46 +01:00
Emmanuel Engelhart 60fbe7f714
Better triggers for packages builds 2023-02-11 16:55:45 +01:00
Matthieu Gautier 595817852d
Merge pull request #894 from kiwix/zerocount_catalog_query 2023-02-10 19:28:53 +01:00
Veloman Yunkan 2e0124710a `?count=0` OPDS catalog queries return 0 results 
... which is a useful way of finding out the total number of results
with the least consumption of resources.
 2023-02-10 19:15:29 +01:00
Veloman Yunkan 340fadd9be Testing of /catalog/search?count=-1 2023-02-10 19:13:33 +01:00
Veloman Yunkan 4bdc1d76c6 Testing of /catalog/v2/entries for count={0,-1} 2023-02-10 19:11:39 +01:00
Veloman Yunkan 738c06ada6
Merge pull request #892 from kiwix/jsonico_mimetypes 
A better favicon.ico with correct MIME-type
 2023-02-10 18:13:28 +04:00
Veloman Yunkan 93bb0f098b A slightly better favicon.ico 
Replaced the favicon embedded in kiwix-serve with a slightly better one
(taken from https://www.kiwix.org/favicon.ico).
 2023-02-10 15:07:00 +01:00
Veloman Yunkan e8c8a297b5 Registered MIME-types for .ico and .json 
As a result, favicon.ico stopped being considered a compressible resource.
 2023-02-10 15:07:00 +01:00
Veloman Yunkan f4f7879ff3 New unit test ServerTest.MimeTypes 
The new unit test demonstrates that for embedded resources with .ico and
.json extensions MIME-types are incorrect.
 2023-02-10 15:07:00 +01:00
Kelson 706108256b
Merge pull request #891 from kiwix/hbsLang 
Add Serbo-croate language name
 2023-02-10 09:33:34 +01:00
Nikhil Tanwar 12f0614350 Add Serbo-croate language name 
Adds "srpskohrvatski" as name for "hbs" language tag.
 2023-02-10 09:20:23 +05:30
Matthieu Gautier 29519df906
Merge pull request #882 from kiwix/rssFeed 2023-02-09 16:43:52 +01:00
Nikhil Tanwar 6b8f9aa6ab Add specific link for Kiwix RSS Feed 
Added an image of rss logo on the welcome page which links to the RSS feed with current filters
 2023-02-09 20:50:52 +05:30
Nikhil Tanwar e3a211e41c Add RSS Feed extension in head 
This change adds a <link> element in the head node of welcome page.
Browsers with extensions for RSS will show a sign to navigate to the feed.
The link changes based on current set filters.
 2023-02-09 20:47:32 +05:30
Matthieu Gautier fa80be87be
Merge pull request #890 from kiwix/url_encoding_of_redirects 2023-02-09 11:22:21 +01:00
Veloman Yunkan 51206f4037 fixup! URI-encoding when redirecting legacy URLs to /content 
The alleged bug seems rather an issue with httplib which seems to
URI-encode any + present in query parameters.
 2023-02-09 11:10:37 +01:00
Veloman Yunkan c2fffacbbd Renamed a data member 2023-02-09 10:40:23 +01:00
Veloman Yunkan 02f631fdb6 Got rid of RequestContext::full_url 2023-02-09 10:40:23 +01:00
Veloman Yunkan 05a66ead6e URI-encoding of the root location part 
Now the root location is URI-encoded too.

In order to properly test this change the root location in the tests was
changed from "/ROOT" to "/ROOT#?" (or "/ROOT%23%3F" in URI-encoded form),
which is why this commit is so big.
 2023-02-09 10:40:07 +01:00
Veloman Yunkan 97f0314fe6 Saving a few CPU cycles 
This silly optimization in fact helps to avoid a somewhat more serious
waste of CPU cycles that would otherwise result in the next commit.
 2023-02-08 22:16:27 +01:00
Veloman Yunkan a7fe4193e3 Preparing to save a few CPU cycles 2023-02-08 22:16:27 +01:00
Veloman Yunkan 2c5e84b6b3 Simpler fullURL2LocalURL() 2023-02-08 22:16:27 +01:00
Veloman Yunkan 71a66e0528 Passing of unrooted URL into RequestContext() 
This change doesn't make much sense on its own - the real goal is to
prepare some ground for easier implementation of URI-encoding of the root
location.
 2023-02-08 22:16:27 +01:00
Veloman Yunkan a807ce27f1 URI-encoding when redirecting legacy URLs to /content 
Testing of this functionality revealed that the query part containing +
symbols (as replacement for spaces in the parameter values) isn't
forwarded properly as the + symbols are URI-encoded (this is a bug on
the part of the `RequestContext::get_query()` the result of which
already contains URI-encoded +'s).
 2023-02-08 22:16:27 +01:00
Veloman Yunkan 58bb8b9843 ServerTest.RandomPageRedirectionsAreUrlEncoded 2023-02-08 22:16:27 +01:00
Veloman Yunkan 2e9bec95b0 Proper URI-encoding in InternalServer::build_redirect() 
- Before this change `InternalServer::build_redirect()` only URI-encoded the
  article path, ignoring the book name and/or the root location components of
  the URL.

- In order to be able to test this fix, corner_cases.zim was renamed to
  contain a couple of special URL symbols in its filename. The
  `create_corner_cases_zim_file` script was updated accordingly.
 2023-02-08 22:16:09 +01:00
Matthieu Gautier 2f419996ab
Merge pull request #886 from kiwix/thread_aria 2023-02-08 16:21:52 +01:00
Matthieu Gautier 1ba588272c Get `Waiting` downloads before `Active` ones. 
`Waiting` can become `Active` while we are getting the downloads.
We may have rare case where we miss a download if we get `Active` before
`Waiting`.
 2023-02-08 15:42:17 +01:00
Matthieu Gautier 2c3b7409aa Remove the default value of follow parameter in `updateStatus`. 
`false` is a pretty bad default value as most user want to track
the real download.

By removing the default value, we force user to make a choice.
We could have change the default value to true but it would have been
a silent API change and we don't want that.
 2023-02-08 15:42:17 +01:00
Matthieu Gautier f239f2de18 Add documentation. 2023-02-08 15:42:17 +01:00
Matthieu Gautier 18b7b5f277 Mark constant methods as const. 2023-02-08 15:42:17 +01:00
Matthieu Gautier 0e612de4d1 Make `Downloader` return shared_ptr instead of raw pointer. 
This is dangerous by nature to return raw pointer on internal data.
 2023-02-08 15:42:17 +01:00
Matthieu Gautier 52ae5c3a5f Make Downloader thread safe. 2023-02-08 15:42:17 +01:00
Matthieu Gautier d1fe1b89ae Do not automatically update the status of existing Download. 
User may already have a pointer to the `Download` and it is not protected
against concurrent access.

We could update the status of new created `Download` as by definition,
no one have a pointer on it.
But it better to not do it neither :
- For consistency
- Because the first call on update status may be long on windows (because
  of file preallocation). It is better to not block the downloader for that.
 2023-02-08 15:42:17 +01:00
Matthieu Gautier 1aa8521e15 Remove the lock. 
As we now build a new request handle for every request, we don't need
a lock.

libcurl itself is thread safe as long as we don't share a handle.
 2023-02-08 15:42:17 +01:00
Matthieu Gautier 95ebb6a492 Build a new curl "handle" at everyrequest instead of reusing the same one. 2023-02-08 15:42:17 +01:00