mirror of
https://github.com/kiwix/libkiwix.git
synced 2025-06-28 05:49:35 +00:00
93197f8175
Before this fix clicking an external link in the viewer iframe had no effect (other than an error being reported in the browser dev tools console) because the attempt to navigate the top browser context was suppressed due to sandboxing - the click handling code changed the target of the link but navigating to that target was blocked. Now the click handler works as follows: 1. Changes the target of the link to the catch page only if the link is going to be opened in a new tab or window (in this case sandboxing restrictions do not apply). 2. Otherwise directly navigates the viewer window to external URL or the catch page. An unhandled scenario is opening an external link in a new tab/window via a middle click or context menu - such events cannot be intercepted and therefore there is no way of blocking external links accessed in the said way.