mirror of https://github.com/kiwix/libkiwix.git
3b9f28b2b5
The story of search_results.css static/skin/search_results.css was extracted from static/templates/no_search_result.html before the latter was dropped. static/templates/no_search_result.html in turn seems to be a copied and edited version of static/templates/search_result.html. In the context of exploratory work on the internationalization of kiwix-serve (PR #679) I noticed duplication of inline CSS across those two templates and intended to eliminated it. That goal was not fully accomplished (static/templates/search_result.html remained untouched) because by that time PR #679 grew too big and the efforts were diverted into splitting it into smaller ones. Thus search_results.css slipped into one of those small PRs, without making much sense because nothing really justifies preserving custom CSS in the "Fulltext search unavailable" error page. At the same time, it served as the only case where a link to a cacheable resource is generated in C++ code (rather than found in a template). This poses certain problems to the handling of cache-ids. A workaround is to expel the URL into a template so that it is processed by `kiwix-resources`. This commit merely demonstrates that solution. But whether it should be preserved (or rather the "Fulltext search unavailable" page should be deprived of CSS) is questionable. |
||
|---|---|---|
| .. | ||
| captured_external.html | ||
| catalog_entries.xml | ||
| catalog_v2_categories.xml | ||
| catalog_v2_entries.xml | ||
| catalog_v2_entry.xml | ||
| catalog_v2_languages.xml | ||
| catalog_v2_root.xml | ||
| error.html | ||
| external_blocker_part.html | ||
| head_taskbar.html | ||
| index.html | ||
| search_result.html | ||
| suggestion.json | ||
| taskbar_part.html | ||
| url_of_search_results_css | ||