smallsolar
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

build: add --no-user for pip commands in Makefile 

I ran into "Cannot combine --user and --target" in an environment and
adding --no-user seemed to fix it.

Refs: https://stackoverflow.com/a/67259534/436641

PR-URL: https://github.com/nodejs/node/pull/40169
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Christian Clauss <cclauss@me.com>
This commit is contained in:
Rich Trott 2021-09-21 05:08:08 +00:00 committed by Node.js GitHub Bot
parent c7da13c7c4
commit 18e527c32f
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Makefile
View File

@ -1392,8 +1392,8 @@ cpplint: lint-cpp
# Try with '--system' if it fails without; the system may have set '--user'
lint-py-build:
$(info Pip installing flake8 linter on $(shell $(PYTHON) --version)...)
$(PYTHON) -m pip install --upgrade -t tools/pip/site-packages flake8 || \
$(PYTHON) -m pip install --upgrade --system -t tools/pip/site-packages flake8
$(PYTHON) -m pip install --no-user --upgrade -t tools/pip/site-packages flake8 || \
$(PYTHON) -m pip install --no-user --upgrade --system -t tools/pip/site-packages flake8
ifneq ("","$(wildcard tools/pip/site-packages/flake8)")
.PHONY: lint-py
@ -1412,8 +1412,8 @@ endif
# Try with '--system' if it fails without; the system may have set '--user'
lint-yaml-build:
$(info Pip installing yamllint on $(shell $(PYTHON) --version)...)
$(PYTHON) -m pip install --upgrade -t tools/pip/site-packages yamllint || \
$(PYTHON) -m pip install --upgrade --system -t tools/pip/site-packages yamllint
$(PYTHON) -m pip install --no-user --upgrade -t tools/pip/site-packages yamllint || \
$(PYTHON) -m pip install --no-user --upgrade --system -t tools/pip/site-packages yamllint
.PHONY: lint-yaml
# Lints the YAML files with yamllint.