smallsolar
/
node
mirror of https://github.com/nodejs/node.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

cluster: use ObjectPrototypeHasOwnProperty 

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/48141
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This commit is contained in:
Daeyeon Jeong 2023-05-26 01:04:19 +09:00 committed by GitHub
parent 00fcff575e
commit b4d5f1f26d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/cluster.js
View File

@ -21,5 +21,9 @@
'use strict';
const childOrPrimary = 'NODE_UNIQUE_ID' in process.env ? 'child' : 'primary';
const {
ObjectPrototypeHasOwnProperty: ObjectHasOwn,
} = primordials;
const childOrPrimary = ObjectHasOwn(process.env, 'NODE_UNIQUE_ID') ? 'child' : 'primary';
module.exports = require(`internal/cluster/${childOrPrimary}`);

17
test/parallel/test-cluster-basic.js
View File

@ -22,13 +22,26 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const cluster = require('cluster');
const assert = require('node:assert');
const cluster = require('node:cluster');
const { spawnSync } = require('node:child_process');
assert.strictEqual('NODE_UNIQUE_ID' in process.env, false,
`NODE_UNIQUE_ID (${process.env.NODE_UNIQUE_ID}) ` +
'should be removed on startup');
{
const { status } = spawnSync(process.execPath, [
'-e',
`
const { strictEqual } = require('node:assert');
Object.setPrototypeOf(process.env, { NODE_UNIQUE_ID: 0 });
strictEqual(require('cluster').isPrimary, true);
`,
]);
assert.strictEqual(status, 0);
}
function forEach(obj, fn) {
Object.keys(obj).forEach((name, index) => {
fn(obj[name], name, index);