From 2f4937c52d7c14edd29f2658410c7f1f7adf55ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pablo=20Correa=20G=C3=B3mez?= <ablocorrea@hotmail.com>
Date: Mon, 29 May 2023 23:42:14 +0200
Subject: [PATCH] deviceinfo: add tests for ReadDeviceinfo (MR 37)

---
 pkgs/deviceinfo/deviceinfo_test.go            | 26 +++++++++++++++++++
 .../test_resources/deviceinfo-first           |  2 ++
 pkgs/deviceinfo/test_resources/deviceinfo-msm |  1 +
 3 files changed, 29 insertions(+)
 create mode 100644 pkgs/deviceinfo/test_resources/deviceinfo-first
 create mode 100644 pkgs/deviceinfo/test_resources/deviceinfo-msm

diff --git a/pkgs/deviceinfo/deviceinfo_test.go b/pkgs/deviceinfo/deviceinfo_test.go
index 452e64a..ceb6bc7 100644
--- a/pkgs/deviceinfo/deviceinfo_test.go
+++ b/pkgs/deviceinfo/deviceinfo_test.go
@@ -10,6 +10,32 @@ import (
 	"testing"
 )
 
+// Test ReadDeviceinfo and the logic of reading from multiple files
+func TestReadDeviceinfo(t *testing.T) {
+	modules_expected := "panfrost foo bar bazz"
+	mesa_expected := "msm"
+
+	var devinfo DeviceInfo
+	err := devinfo.ReadDeviceinfo("./test_resources/deviceinfo-missing")
+	if !strings.Contains(err.Error(), "required by mkinitfs") {
+		t.Errorf("received an unexpected err: %s", err)
+	}
+	err = devinfo.ReadDeviceinfo("./test_resources/deviceinfo-first")
+	if err != nil {
+		t.Errorf("received an unexpected err: %s", err)
+	}
+	err = devinfo.ReadDeviceinfo("./test_resources/deviceinfo-msm")
+	if err != nil {
+		t.Errorf("received an unexpected err: %s", err)
+	}
+	if devinfo.ModulesInitfs != modules_expected {
+		t.Errorf("expected %q, got: %q", modules_expected, devinfo.ModulesInitfs)
+	}
+	if devinfo.MesaDriver != mesa_expected {
+		t.Errorf("expected %q, got: %q", mesa_expected, devinfo.MesaDriver)
+	}
+}
+
 // Test conversion of name to DeviceInfo struct field format
 func TestNameToField(t *testing.T) {
 	tables := []struct {
diff --git a/pkgs/deviceinfo/test_resources/deviceinfo-first b/pkgs/deviceinfo/test_resources/deviceinfo-first
new file mode 100644
index 0000000..6492ca1
--- /dev/null
+++ b/pkgs/deviceinfo/test_resources/deviceinfo-first
@@ -0,0 +1,2 @@
+deviceinfo_modules_initfs="panfrost foo bar bazz"
+deviceinfo_mesa_driver="panfrost"
diff --git a/pkgs/deviceinfo/test_resources/deviceinfo-msm b/pkgs/deviceinfo/test_resources/deviceinfo-msm
new file mode 100644
index 0000000..e73e3a9
--- /dev/null
+++ b/pkgs/deviceinfo/test_resources/deviceinfo-msm
@@ -0,0 +1 @@
+deviceinfo_mesa_driver="msm"
\ No newline at end of file