From 4074eada55ba3e577bd6d2b4f94a78c7f43c9577 Mon Sep 17 00:00:00 2001 From: Clayton Craft Date: Tue, 21 Feb 2023 10:38:01 -0800 Subject: [PATCH] modules: remove TODOs The builtin one was moved to a new issue: https://gitlab.com/postmarketOS/postmarketos-mkinitfs/-/issues/18 The "more extensions" one was not moved to a new issue, it should be obvious if we do need to support more extensions. --- internal/filelist/modules/modules.go | 3 --- 1 file changed, 3 deletions(-) diff --git a/internal/filelist/modules/modules.go b/internal/filelist/modules/modules.go index 01ff736..74d4580 100644 --- a/internal/filelist/modules/modules.go +++ b/internal/filelist/modules/modules.go @@ -127,7 +127,6 @@ func slurpModules(fd io.Reader, modDir string) (*filelist.FileList, error) { func getModulesInDir(modPath string) (files []string, err error) { err = filepath.Walk(modPath, func(path string, f os.FileInfo, err error) error { - // TODO: need to support more extensions? if filepath.Ext(path) != ".ko" && filepath.Ext(path) != ".xz" { return nil } @@ -145,8 +144,6 @@ func getModulesInDir(modPath string) (files []string, err error) { // file and all of its dependencies. // Note: it's not necessarily fatal if the module is not found, since it may // have been built into the kernel -// TODO: look for it in modules.builtin, and make it fatal if it can't be found -// anywhere func getModule(modName string, modDir string) (files []string, err error) { modDep := filepath.Join(modDir, "modules.dep")