smallsolar/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

dm: core: Use dev_has_ofnode() instead of dev_of_valid()

Browse Source 
We have two functions which do the same thing. Standardise on
dev_has_ofnode() since there is no such thing as an 'invalid' ofnode in
normal operation: it is either null or missing.

Also move the functions into one place.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
This commit is contained in:
Simon Glass
2020-12-19 10:40:13 -07:00
parent c23405f817
commit 7d14ee443c
15 changed files with 30 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
include/dm/device.h
View File

@@ -192,6 +192,17 @@ static inline void dev_bic_flags(struct udevice *dev, u32 bic)
dev->flags_ &= ~bic;
}
/**
* dev_ofnode() - get the DT node reference associated with a udevice
*
* @dev: device to check
* @return reference of the the device's DT node
*/
static inline ofnode dev_ofnode(const struct udevice *dev)
{
return dev->node;
}
/* Returns non-zero if the device is active (probed and not removed) */
#define device_active(dev) (dev_get_flags(dev) & DM_FLAG_ACTIVATED)
@@ -200,7 +211,7 @@ static inline int dev_of_offset(const struct udevice *dev)
return ofnode_to_offset(dev->node);
}
static inline bool dev_has_ofnode(struct udevice *dev)
static inline bool dev_has_ofnode(const struct udevice *dev)
{
return ofnode_valid(dev->node);
}

16
include/dm/read.h
View File

@@ -30,22 +30,6 @@ static inline const struct device_node *dev_np(const struct udevice *dev)
}
#endif
/**
* dev_ofnode() - get the DT node reference associated with a udevice
*
* @dev: device to check
* @return reference of the the device's DT node
*/
static inline ofnode dev_ofnode(const struct udevice *dev)
{
return dev->node;
}
static inline bool dev_of_valid(const struct udevice *dev)
{
return ofnode_valid(dev_ofnode(dev));
}
#ifndef CONFIG_DM_DEV_READ_INLINE
/**