smallsolar/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

spl: Remove NULL assignments in spl_load_info

Browse Source 
Remove NULL assignments to fields in spl_load_info when .load doesn't
reference these fields. This can result in more efficient code. filename
must stay even if it is unused, since load_simple_fit uses it.

Signed-off-by: Sean Anderson <seanga2@gmail.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Sean Anderson
2023-11-08 11:48:37 -05:00
committed by Tom Rini
parent 517e70856f
commit feaeb8fa6f
6 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
common/spl/spl_fat.c
View File

@@ -99,7 +99,6 @@ int spl_load_image_fat(struct spl_image_info *spl_image,
load.read = spl_fit_read;
load.bl_len = 1;
load.filename = (void *)filename;
load.priv = NULL;
return spl_load_simple_fit(spl_image, &load, 0, header);
} else {

2
common/spl/spl_mmc.c
View File

@@ -106,7 +106,6 @@ int mmc_load_image_raw_sector(struct spl_image_info *spl_image,
debug("Found FIT\n");
load.dev = mmc;
load.priv = NULL;
load.filename = NULL;
load.bl_len = mmc->read_bl_len;
load.read = h_spl_load_read;
@@ -116,7 +115,6 @@ int mmc_load_image_raw_sector(struct spl_image_info *spl_image,
struct spl_load_info load;
load.dev = mmc;
load.priv = NULL;
load.filename = NULL;
load.bl_len = mmc->read_bl_len;
load.read = h_spl_load_read;

4
common/spl/spl_nand.c
View File

@@ -91,7 +91,6 @@ static int spl_nand_load_element(struct spl_image_info *spl_image,
struct spl_load_info load;
debug("Found FIT\n");
load.dev = NULL;
load.priv = &offset;
load.filename = NULL;
load.bl_len = bl_len;
@@ -101,7 +100,6 @@ static int spl_nand_load_element(struct spl_image_info *spl_image,
valid_container_hdr((void *)header)) {
struct spl_load_info load;
load.dev = NULL;
load.priv = &offset;
load.filename = NULL;
load.bl_len = bl_len;
@@ -112,8 +110,6 @@ static int spl_nand_load_element(struct spl_image_info *spl_image,
struct spl_load_info load;
debug("Found legacy image\n");
load.dev = NULL;
load.priv = NULL;
load.filename = NULL;
load.bl_len = IS_ENABLED(CONFIG_SPL_LZMA) ? bl_len : 1;
load.read = spl_nand_legacy_read;

2
common/spl/spl_spi.c
View File

@@ -152,7 +152,6 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,
debug("Found FIT\n");
load.dev = flash;
load.priv = NULL;
load.filename = NULL;
load.bl_len = 1;
load.read = spl_spi_fit_read;
@@ -164,7 +163,6 @@ static int spl_spi_load_image(struct spl_image_info *spl_image,
struct spl_load_info load;
load.dev = flash;
load.priv = NULL;
load.filename = NULL;
load.bl_len = 1;
load.read = spl_spi_fit_read;

1
common/spl/spl_ymodem.c
View File

@@ -134,7 +134,6 @@ int spl_ymodem_load_image(struct spl_image_info *spl_image,
struct ymodem_fit_info info;
debug("Found FIT\n");
load.dev = NULL;
load.priv = (void *)&info;
load.filename = NULL;
load.bl_len = 1;