Emmanuel Engelhart
5a9dbf85ec
Fix title='_' case too #685
2022-01-24 08:35:36 +01:00
Kelson
cd412867d9
Merge pull request #688 from kiwix/legoktm-patch-1
2022-01-24 06:42:52 +01:00
Kunal Mehta
01edd830bc
PPA: Fix libzim-dev dependency
...
Our libzim packages are "7.2.0~focal" but the ~ means that "7.2.0" is greater than
"7.2.0~focal" so the dependency can't be satisfied. Depending on "7.2.0~" will
allow "7.2.0~focal" to satisfy the dependency.
2022-01-23 20:30:23 -08:00
Kelson
ceb46f1069
Merge pull request #687 from kiwix/langCatBoxFill
...
Add undefined check for humanFriendlyTitle
2022-01-23 20:39:48 +01:00
Nikhil Tanwar
270773d6ba
Add undefined check for humanFriendlyTitle
...
humanFriendlyTitle() now returns an empty string if title is undefined
which is handled in loadAndDisplayOptions()
2022-01-23 20:33:46 +01:00
Kelson
234606b170
Merge pull request #686 from kiwix/catalog_search_with_zero_count
2022-01-22 08:47:06 +01:00
Veloman Yunkan
b8328a78f6
/catalog/search?count=0 returns all entries
2022-01-21 19:31:46 +04:00
Veloman Yunkan
08c3a9d8b2
Testing of /catalog/search?count=0
2022-01-21 19:28:16 +04:00
Matthieu Gautier
744065276b
Merge pull request #682 from kiwix/fix_test_compilation_windows
2022-01-19 16:22:16 +01:00
Matthieu Gautier
e3f8046915
Do not include posix header on Windows
...
They are included by 3dbcbe5
which need them to test permission rights on
posix only.
2022-01-19 16:15:59 +01:00
Matthieu Gautier
3198a849e2
Merge pull request #681 from kiwix/version_10.0.0
2022-01-19 16:08:08 +01:00
Matthieu Gautier
fcae21c55b
Update Changelog
2022-01-19 16:02:39 +01:00
Matthieu Gautier
7da81acaa3
Update libzim dependency version to 7.2.0
2022-01-19 16:02:39 +01:00
Matthieu Gautier
a7d19b170a
Update .gitignore
2022-01-19 12:47:40 +01:00
Matthieu Gautier
000029166b
Fix the copyright in the doc configuration
2022-01-19 12:47:00 +01:00
Kelson
2ccea8e370
Merge pull request #680 from kiwix/fix_windows_compilation
...
Add a new private constructor not deprecated for Reader.
2022-01-18 16:31:32 +01:00
Matthieu Gautier
84587e7f03
Add a new private constructor not deprecated for Reader.
...
As we still create a `Reader` in the deprecated code of `Library`,
we need a way to create a reader without raising a deprecated warning.
So we create a another constructor with a dummy argument and we use it.
2022-01-18 12:22:11 +01:00
Kelson
38fc187303
Merge pull request #678 from kiwix/depends_libzim_7.1.0
...
Needs libzim 7.1.0 getMetadataItem()
2022-01-16 09:59:54 +01:00
Emmanuel Engelhart
2dc8fc9ab3
Needs libzim 7.1.0 getMetadataItem()
2022-01-15 15:57:04 +01:00
Kelson
60b4be2286
Merge pull request #676 from kiwix/customURLfix
...
Remove {root} from book item's link in library
2022-01-14 16:31:16 +01:00
Nikhil Tanwar
a8a68c54a2
Remove {root} from book item's link in library
...
The OPDS stream now provides full URL, including the custom root
Appending {root} duplicates the custom root, when given resulting in a broken link
2022-01-14 16:23:52 +01:00
Kelson
367e5d2636
Merge pull request #675 from kiwix/fix_android
...
Revert removing of deprecated methods used by android wrapper.
2022-01-14 16:19:14 +01:00
Matthieu Gautier
fcd865bb81
Revert removing of deprecated methods used by android wrapper.
2022-01-14 12:28:50 +01:00
Matthieu Gautier
715151d725
Merge pull request #674 from kiwix/deprecated
2022-01-13 14:32:28 +01:00
Matthieu Gautier
e5eeb08206
Remove old deprecated methods.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
ac6f91798f
Assume `SuggestionItem` has a public constructor.
...
`SuggestionItem` is somehow a simple container.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
e5d26a4699
Deprecate `SearchRenderer` creation from a `Searcher`.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
3d64a9d9a9
Deprecate `Searcher` creation.
...
As the `Searcher` is now deprecated, we also remove the unit tests on it.
`Searcher` is now untested, and so it reduces the code coverage.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
fb7d9f02c8
Deprecate `Reader` creation.
...
As we `Reader` is now deprecated, we also remove the unit tests on it.
`Reader` is now untested, and so it reduces the code coverage.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
96e0d15ab4
Deprecate `Entry` creation.
...
As the `Entry` is still created by `Reader` we need a way to create a
entry without raising a deprecated warning.
To do so we create a second constructor with a dummy argument.
This second constructor is private and is not marked as deprecated so we
can use it.
2022-01-13 14:23:29 +01:00
Matthieu Gautier
39732e2bcf
Deprecate methods on Book.
...
- `update(const Reader& reader)` is replaced by
`update(const zim::Archive& archive)`
- `getFavicon*()` is replaced by `getIllustration(48)->*`
2022-01-12 18:07:46 +01:00
Kelson
7dfafe0196
Merge pull request #673 from kiwix/urlEncode
2022-01-12 13:19:54 +01:00
Matthieu Gautier
3052d0787a
UrlEncode the `content_id`.
...
The HumanReadableId can contains special char (`&`/`=`/...)
As it is used as to create a url in the opds template,
we must url encode it.
- We don't need to encode the book id as it is a uuid, it never contains
special char.
- We don't need to encode the book url as it is read from the library and
the url must already be correctly encoded in the library.xml.
(tests modified accordingly)
2022-01-11 17:53:29 +01:00
Kelson
d4db090bb9
Merge pull request #672 from kiwix/LadakhiISO
...
Add new method for language code
2022-01-11 15:39:49 +01:00
Nikhil Tanwar
0633f68f80
Add new values from wikipedia
...
Added new values. This now covers all iso 639-1 codes from https://en.wikipedia.org/wiki/List_of_ISO_639-1_codes
2022-01-11 15:32:06 +01:00
Nikhil Tanwar
2a5db3e7ab
Use iso6391to3.js for language tag value
...
Improves upon the previous method of truncating language to first 2 values which was showing wrong values
2022-01-11 15:31:55 +01:00
Matthieu Gautier
468a080b09
Merge pull request #669 from kiwix/remove_meta_endpoints
2022-01-10 13:44:23 +01:00
Matthieu Gautier
1705f938b5
Extend unittest to check 404 error on wrong raw endpoints.
...
Check that `/raw` endpoint behaves correctly with wrong book name or
wrong kind.
2022-01-10 13:13:27 +01:00
Matthieu Gautier
0112e6102d
Remove the meta endpoint in the server.
...
Now we have `/raw` and `catalog/v2/illustration` endpoints we don't need
to keep the meta endpoint.
2022-01-10 13:13:27 +01:00
Kelson
e4d99f0374
Merge pull request #668 from kiwix/fileExists
...
Introduce kiwix::fileReadable
2022-01-09 20:16:56 +01:00
Emmanuel Engelhart
aa50845e22
Fix small typos in comments
2022-01-09 20:05:30 +01:00
Nikhil Tanwar
3dbcbe542b
Add tests for kiwix::fileExists and kiwix::fileReadable
2022-01-10 00:18:44 +05:30
Nikhil Tanwar
854058f842
Introduce kiwix::fileReadable
...
kiwix::fileExists only checks for file existence now
kiwix::fileReadable will check if the file is readable (implicitly checking for file existence also)
2022-01-05 20:16:38 +05:30
Matthieu Gautier
c9eb3196f7
Merge pull request #646 from kiwix/raw_endpoints
2022-01-05 15:31:35 +01:00
Matthieu Gautier
dc15a9a824
Add `raw` endpoint.
...
As the name suggests it, this endpoint is not smart :
It returns the content as it is and only if it is present
(no compatibility or whatever).
The only "smart" thing is to return a redirect if the entry is a redirect.
2022-01-05 15:12:41 +01:00
Matthieu Gautier
160a74f5f8
Extend ItemResponse and ContentResponse to return raw content.
2022-01-05 15:12:41 +01:00
Matthieu Gautier
78c10346f2
Merge pull request #645 from kiwix/illustration_api
2022-01-04 14:34:00 +01:00
Matthieu Gautier
6f1799db9f
Use the new endpoint in the OPDS stream.
2022-01-04 14:16:46 +01:00
Matthieu Gautier
e108fb0e47
Add `/catalog/v2/illustration` endpoint
2022-01-04 14:16:46 +01:00
Matthieu Gautier
9482bfb95b
Add a method to get the a book illustration for a specific size.
2022-01-04 14:16:46 +01:00