smallsolar/postmarketos-mkinitfs
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

modules: remove TODOs

Browse Source 
The builtin one was moved to a new issue:
https://gitlab.com/postmarketOS/postmarketos-mkinitfs/-/issues/18

The "more extensions" one was not moved to a new issue, it should be
obvious if we do need to support more extensions.
This commit is contained in:
Clayton Craft
2023-02-21 10:38:01 -08:00
parent a7c4fe83ce
commit 4074eada55
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
internal/filelist/modules/modules.go
View File

@@ -127,7 +127,6 @@ func slurpModules(fd io.Reader, modDir string) (*filelist.FileList, error) {
func getModulesInDir(modPath string) (files []string, err error) { func getModulesInDir(modPath string) (files []string, err error) {
err = filepath.Walk(modPath, func(path string, f os.FileInfo, err error) error { err = filepath.Walk(modPath, func(path string, f os.FileInfo, err error) error {
// TODO: need to support more extensions?
if filepath.Ext(path) != ".ko" && filepath.Ext(path) != ".xz" { if filepath.Ext(path) != ".ko" && filepath.Ext(path) != ".xz" {
return nil return nil
} }
@@ -145,8 +144,6 @@ func getModulesInDir(modPath string) (files []string, err error) {
// file and all of its dependencies. // file and all of its dependencies.
// Note: it's not necessarily fatal if the module is not found, since it may // Note: it's not necessarily fatal if the module is not found, since it may
// have been built into the kernel // have been built into the kernel
// TODO: look for it in modules.builtin, and make it fatal if it can't be found
// anywhere
func getModule(modName string, modDir string) (files []string, err error) { func getModule(modName string, modDir string) (files []string, err error) {
modDep := filepath.Join(modDir, "modules.dep") modDep := filepath.Join(modDir, "modules.dep")