smallsolar/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

sandbox: missing return value checks in eth-raw-os

Browse Source 
We should check the return value of fcntl().

Addresses-Coverity-ID: 131108 ("Unchecked return value from library")
Addresses-Coverity-ID: 131109 ("Unchecked return value from library")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
This commit is contained in:
Heinrich Schuchardt
2024-01-07 09:27:12 +01:00
committed by Tom Rini
parent d5e6401011
commit 233c31d7ba
1 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
arch/sandbox/cpu/eth-raw-os.c
View File

@@ -105,7 +105,12 @@ static int _raw_packet_start(struct eth_sandbox_raw_priv *priv,
/* Make the socket non-blocking */
flags = fcntl(priv->sd, F_GETFL, 0);
fcntl(priv->sd, F_SETFL, flags | O_NONBLOCK);
ret = fcntl(priv->sd, F_SETFL, flags | O_NONBLOCK);
if (ret == -1) {
printf("Failed to make socket non-blocking: %d %s\n", errno,
strerror(errno));
return -errno;
}
/* Enable promiscuous mode to receive responses meant for us */
mr.mr_ifindex = device->sll_ifindex;
@@ -172,7 +177,12 @@ static int _local_inet_start(struct eth_sandbox_raw_priv *priv)
/* Make the socket non-blocking */
flags = fcntl(priv->sd, F_GETFL, 0);
fcntl(priv->sd, F_SETFL, flags | O_NONBLOCK);
ret = fcntl(priv->sd, F_SETFL, flags | O_NONBLOCK);
if (ret == -1) {
printf("Failed to make socket non-blocking: %d %s\n", errno,
strerror(errno));
return -errno;
}
/* Include the UDP/IP headers on send and receive */
ret = setsockopt(priv->sd, IPPROTO_IP, IP_HDRINCL, &one,