smallsolar/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rockchip: adc: rockchip-saradc: factor out stop callback

Browse Source 
SARADC v2 doesn't have a stop mechanism once in single mode. In series
conversion, the logic is different anyway. Therefore, let's abstract
this function so that it can be provided from the udevice.data pointer.

Cc: Quentin Schulz <foss+uboot@0leil.net>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
This commit is contained in:
Quentin Schulz
2024-03-14 10:36:23 +01:00
committed by Kever Yang
parent 2577525512
commit d63c57e104
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/adc/rockchip-saradc.c
View File

@@ -39,6 +39,7 @@ struct rockchip_saradc_data {
unsigned long clk_rate;
int (*channel_data)(struct udevice *dev, int channel, unsigned int *data);
int (*start_channel)(struct udevice *dev, int channel);
int (*stop)(struct udevice *dev);
};
struct rockchip_saradc_priv {
@@ -124,13 +125,29 @@ int rockchip_saradc_start_channel(struct udevice *dev, int channel)
return 0;
}
int rockchip_saradc_stop(struct udevice *dev)
int rockchip_saradc_stop_v1(struct udevice *dev)
{
struct rockchip_saradc_priv *priv = dev_get_priv(dev);
/* Power down adc */
writel(0, &priv->regs.v1->ctrl);
return 0;
}
int rockchip_saradc_stop(struct udevice *dev)
{
struct rockchip_saradc_priv *priv = dev_get_priv(dev);
if (priv->data->stop) {
int ret = priv->data->stop(dev);
if (ret) {
pr_err("Error stopping channel, %d!", ret);
return ret;
}
}
priv->active_channel = -1;
return 0;
@@ -209,6 +226,7 @@ static const struct rockchip_saradc_data saradc_data = {
.clk_rate = 1000000,
.channel_data = rockchip_saradc_channel_data_v1,
.start_channel = rockchip_saradc_start_channel_v1,
.stop = rockchip_saradc_stop_v1,
};
static const struct rockchip_saradc_data rk3066_tsadc_data = {
@@ -217,6 +235,7 @@ static const struct rockchip_saradc_data rk3066_tsadc_data = {
.clk_rate = 50000,
.channel_data = rockchip_saradc_channel_data_v1,
.start_channel = rockchip_saradc_start_channel_v1,
.stop = rockchip_saradc_stop_v1,
};
static const struct rockchip_saradc_data rk3399_saradc_data = {
@@ -225,6 +244,7 @@ static const struct rockchip_saradc_data rk3399_saradc_data = {
.clk_rate = 1000000,
.channel_data = rockchip_saradc_channel_data_v1,
.start_channel = rockchip_saradc_start_channel_v1,
.stop = rockchip_saradc_stop_v1,
};
static const struct udevice_id rockchip_saradc_ids[] = {